New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My blogs/files/pages/bookmarks etc doesn't show my content (Trac #4878) #4878

Closed
elgg-gitbot opened this Issue Feb 16, 2013 · 15 comments

Comments

Projects
None yet
6 participants
@elgg-gitbot

elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4878 on 42758250-07-09 by trac user coldtrick, assigned to unknown.

Elgg version: 1.8

The pages my blogs/pages/files/bookmarks etc doesn't show all my content. It only shows my content with the container_guid = me.

It's very difficult to find a blog I wrote in a group, because I have to go through all different groups to find the specific blog.

In Elgg 1.7 this was different.

Why not show all my content in the case of page_owner == logged in user, the listing will make clear where the content is located.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem May 31, 2013

Member

I really did not like this change made in 1.8, so i hope it can be reverted in 1.9

Member

jdalsem commented May 31, 2013

I really did not like this change made in 1.8, so i hope it can be reverted in 1.9

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola
Member

juho-jaakkola commented May 31, 2013

👍

@cash

This comment has been minimized.

Show comment
Hide comment
@cash

cash May 31, 2013

Contributor

We did not make a change!!!

Contributor

cash commented May 31, 2013

We did not make a change!!!

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola May 31, 2013

Member

Anyhow I'm in favor of making the proposed change. There have been many users saying that their content has "disappeared" because they don't realize group content isn't displayed in the lists.

Or at least I can't think of a any other way to make this more logical for the users...

Member

juho-jaakkola commented May 31, 2013

Anyhow I'm in favor of making the proposed change. There have been many users saying that their content has "disappeared" because they don't realize group content isn't displayed in the lists.

Or at least I can't think of a any other way to make this more logical for the users...

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay May 31, 2013

Member

Two tools this could make confusing: blog (it means anything you'be blogged for any group shows up in "your" blog) and pages (how do we draw the hierarchy tree?).

I can see this both ways. I sometimes think an "All my content" would be better, with filters and sorting. Users frequently don't remember what subtype their content was.

Member

mrclay commented May 31, 2013

Two tools this could make confusing: blog (it means anything you'be blogged for any group shows up in "your" blog) and pages (how do we draw the hierarchy tree?).

I can see this both ways. I sometimes think an "All my content" would be better, with filters and sorting. Users frequently don't remember what subtype their content was.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem May 31, 2013

Member

@cash The change dates back to before 1.7. In 1.6 it was common to use list_user_objects functions in the plugins. Those were owner based and not container based. In the rewrite of the list_entities functions in 1.7 this is probably mixed up. Yeah it is a bit old... but still, i would like to see MY blogs on the MY blogs page, even those written in a different container, because it is still my blog :)

Member

jdalsem commented May 31, 2013

@cash The change dates back to before 1.7. In 1.6 it was common to use list_user_objects functions in the plugins. Those were owner based and not container based. In the rewrite of the list_entities functions in 1.7 this is probably mixed up. Yeah it is a bit old... but still, i would like to see MY blogs on the MY blogs page, even those written in a different container, because it is still my blog :)

@cash

This comment has been minimized.

Show comment
Hide comment
@cash

cash May 31, 2013

Contributor

The problem is that we use the same pages for display of content to other users and to the user that created the content. If the user can have a central place to create content, organize it, and so on, it would solve this issue and provide a much better experience.

Contributor

cash commented May 31, 2013

The problem is that we use the same pages for display of content to other users and to the user that created the content. If the user can have a central place to create content, organize it, and so on, it would solve this issue and provide a much better experience.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem May 31, 2013

Member

But we do not have such a system yet, and probably won't make it to 1.9. Also that new content place will still be used by owners, but also by others. Maybe someone could work on a new content plugin that could provide features that allows for easier and more flexible access for content when 1.9 is finished... I think we can get one of clients enthousiastic :)

Member

jdalsem commented May 31, 2013

But we do not have such a system yet, and probably won't make it to 1.9. Also that new content place will still be used by owners, but also by others. Maybe someone could work on a new content plugin that could provide features that allows for easier and more flexible access for content when 1.9 is finished... I think we can get one of clients enthousiastic :)

@cash

This comment has been minimized.

Show comment
Hide comment
@cash

cash May 31, 2013

Contributor

I just installed Elgg 1.6 and wrote a blog post in a group and it did not show up in the listing of my blogs. I am fairly certain Elgg worked this way all the way from 1.0 to now.

Contributor

cash commented May 31, 2013

I just installed Elgg 1.6 and wrote a blog post in a group and it did not show up in the listing of my blogs. I am fairly certain Elgg worked this way all the way from 1.0 to now.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem May 31, 2013

Member

I traced back the code and indeed you are right @cash the end results did not change, but wow, what a mess was it back then...

Nonetheless, people are having a hard time finding their own content back...

Member

jdalsem commented May 31, 2013

I traced back the code and indeed you are right @cash the end results did not change, but wow, what a mess was it back then...

Nonetheless, people are having a hard time finding their own content back...

@cash

This comment has been minimized.

Show comment
Hide comment
@cash

cash May 31, 2013

Contributor

I agree that people can forget where they published content and Elgg should make this easier. I prefer to get a solution for this into 1.9 rather than putting in a temporary work around - especially if the work around causes as many problems as it solves.

Contributor

cash commented May 31, 2013

I agree that people can forget where they published content and Elgg should make this easier. I prefer to get a solution for this into 1.9 rather than putting in a temporary work around - especially if the work around causes as many problems as it solves.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Oct 23, 2013

Member

Is anyone against me changing this behaviour in all bundled Elgg plugins to have the "Mine" filter reflect all entities that you are owner of?

To solve @mrclay 's comment

blog (it means anything you'be blogged for any group shows up in "your" blog)

i suggest we add "in group X" to the listing (if not in a group), just as the river has.

And to solve the other comment

and pages (how do we draw the hierarchy tree?).

we should revert the change where the tree is drawn for ALL pages in a container to just the tree for the current top page, as that change was super strange to begin with (this changed between Elgg 1.7 and 1.8, can't find it in GitHub history however).

Member

jdalsem commented Oct 23, 2013

Is anyone against me changing this behaviour in all bundled Elgg plugins to have the "Mine" filter reflect all entities that you are owner of?

To solve @mrclay 's comment

blog (it means anything you'be blogged for any group shows up in "your" blog)

i suggest we add "in group X" to the listing (if not in a group), just as the river has.

And to solve the other comment

and pages (how do we draw the hierarchy tree?).

we should revert the change where the tree is drawn for ALL pages in a container to just the tree for the current top page, as that change was super strange to begin with (this changed between Elgg 1.7 and 1.8, can't find it in GitHub history however).

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Oct 21, 2014

Member

I'd be in favor of this for blogs, bookmarks, files. But not pages.

Member

ewinslow commented Oct 21, 2014

I'd be in favor of this for blogs, bookmarks, files. But not pages.

@jdalsem jdalsem added this to the Elgg 2.0.x milestone Feb 23, 2015

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 1, 2015

Member

Removing from milestone. This is not important enough to block 2.0.0

Member

ewinslow commented Jul 1, 2015

Removing from milestone. This is not important enough to block 2.0.0

@ewinslow ewinslow removed this from the Elgg 2.0.x milestone Jul 1, 2015

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jul 1, 2015

Member

still going to submit a PR tomorrow 😄

Member

jdalsem commented Jul 1, 2015

still going to submit a PR tomorrow 😄

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 2, 2015

feature(plugins): listing of 'my' content shows content you own
BREAKING CHANGE:
The plugins blog, bookmarks and file have been changed to have their
content listing for "Mine" and "Friends" list content where they are the
owner of. Previously it only listed content created in their container.
This resulted in group content not showing in 'my' content listings.

Fixes #4878

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 2, 2015

feature(plugins): listing of 'my' content shows content you own
BREAKING CHANGE:
The plugins blog, bookmarks and file have been changed to have their
content listing for "Mine" and "Friends" list content where they are the
owner of. Previously it only listed content created in their container.
This resulted in group content not showing in 'my' content listings.

Fixes #4878

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 3, 2015

feature(plugins): listing of 'my' content shows content you own
BREAKING CHANGE:
The plugins blog, bookmarks and file have been changed to have their
content listing for "Mine" and "Friends" list content where they are the
owner of. Previously it only listed content created in their container.
This resulted in group content not showing in 'my' content listings.

Fixes #4878

@jdalsem jdalsem closed this in #8671 Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment