New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement optional X-Sendfile support (Trac #4898) #4898

Closed
elgg-gitbot opened this Issue Feb 16, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@elgg-gitbot

elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4898 on 42841697-05-17 by trac user mrclay, assigned to unknown.

Elgg version: 1.8

[https://github.com/owncloud/core/pull/114 An instructive pull request for Owncloud]. The pull request requires the site admin to set an ENV variable after enabling the HTTPd module, so PHP knows it can trust the X-Sendfile header won't just be ignored; probably a good strategy.

I'd like to do this while removing a bunch of boilerplate download code. I'm not sure is this method always results in Content-Type: octet-stream or if we can use it for icon serving (I assume the latter).

@ewinslow ewinslow added the major label Jul 6, 2014

@ewinslow ewinslow modified the milestones: Elgg 2.0.0, Long Term Future Release Jul 6, 2014

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 18, 2016

Contributor

Do we still want support for X-Sendfile?

Contributor

hypeJunction commented Mar 18, 2016

Do we still want support for X-Sendfile?

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 18, 2016

Member

Yes, I think it would be easy to add to the new File API. Site owner would have to set $CONFIG->sendfile_enabled.

Member

mrclay commented Mar 18, 2016

Yes, I think it would be easy to add to the new File API. Site owner would have to set $CONFIG->sendfile_enabled.

@mrclay mrclay added this to the Elgg 2.x milestone Mar 18, 2016

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 24, 2016

Contributor

Seems that all we need is add BinaryFileResponse::trustXSendfileTypeHeader()

Contributor

hypeJunction commented Mar 24, 2016

Seems that all we need is add BinaryFileResponse::trustXSendfileTypeHeader()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment