Remove duplicate river comments (Trac #4925)

[elgg-gitbot]

Original ticket http://trac.elgg.org/ticket/4925 on 42894121-10-12 by trac user mrclay, assigned to unknown.

Elgg version: 1.8

When an object is new, and contains comments, users may see duplicate comments: some attached to the object's create item, and also individual river items for these.

Before view rendering, we could remove comment items from the river that are already displayed underneath an object. This would make some pages have fewer items that others, but this seems acceptable.

[elgg-gitbot]

trac user rivervanrain wrote on 42895118-05-12

Commit: [https://github.com/RiverVanRain/Elgg/commit/f8359f983877aa5971497bbcf5f1fe87c35ed939]

[elgg-gitbot]

trac user mrclay wrote on 42895638-09-04

rivervanrain but once the object creation item drops off the first page, you'll no longer see new comments at the top of the stream. You need both river items.

If someone posts a new comment, I expect that at the top of the stream, not 3 pages down just because the item commented on is old.

[elgg-gitbot]

trac user webgalli wrote on 42916446-07-20

What about an extra column for last_action and list by last_action?

[ewinslow]

This continues to be a frustrating problem....

[mrclay]

My main project bumps the parent object river item timestamp on receiving a comment and only shows individual comment river items when viewing a single user's stream. This makes the river bounce a lot but still seems more usable than showing comments out of context.

I think I could reduce the bouncing by only bumping when the latest comment is more than N seconds after the last bump time.

[mrclay]

...then highlight comment(s) since the previous bump.

[mrclay]

http://www.slideshare.net/danmckinley/etsy-activity-feeds-architecture (start at slide 36)
https://www.quora.com/What-are-best-practices-for-building-something-like-a-News-Feed
https://github.com/tschellenbach/Stream-Framework/blob/master/README.md

[dranii]

"My main project bumps the parent object river item timestamp on receiving a comment and only shows individual comment river items when viewing a single user's stream. This makes the river bounce a lot but still seems more usable than showing comments out of context."

This is really good - how we can do this in Elgg 1.9.x/ Elgg 1.10 ?

[ewinslow]

@dranii, new features go into 1.11 at this point.

And I really age this could improve things.

[ewinslow]

agree*

[jeabakker]

We changed the all activity listing to not show comments/responses.
So the create blog river activity no longer shows the responses / comments. This way there is no duplication in the listing.
On the activity listing of the user the responses are shown