Move graphics into views system #5105

Closed
ewinslow opened this Issue Feb 20, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@ewinslow
Member

ewinslow commented Feb 20, 2013

Now that we support #4476, we should move the files in _graphics into the views system. Couple reasons:

  1. Cache-busting -- sites will show stale versions unless we update the filename every time we update the image. That's a minor hassle, since you also have to go in and change the version in the CSS/HTML by hand as well.
  2. Overrideable -- would be awesome to be able to drop a new favicon at views/defaut/graphics/favicon.ico or something and have it "just work". Right now the process is:
      1. put a new favicon somewhere in your plugin
      1. override the page/elements/shortcut_icon view with the html needed to define the favicon, including building a URL that points to the correct location in the /mod/ directory (blegh). Default group icon is even worse, since you have to register for a plugin hook or something.
@cash

This comment has been minimized.

Show comment
Hide comment
@cash

cash Apr 20, 2013

Contributor

Pushing this off to 1.10 - needs discussion due to performance concerns

Contributor

cash commented Apr 20, 2013

Pushing this off to 1.10 - needs discussion due to performance concerns

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Apr 21, 2013

Member

Grumble grumble...

Member

ewinslow commented Apr 21, 2013

Grumble grumble...

@ewinslow ewinslow removed this from the Elgg 1.10.0 milestone Jun 13, 2014

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 8, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 8, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 8, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 13, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 14, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 14, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 14, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 14, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 14, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 15, 2015

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 16, 2015

@ewinslow ewinslow closed this in #8434 Jun 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment