Skip to content

CLI installer too early session boot #5294

Closed
Srokap opened this Issue Mar 29, 2013 · 5 comments

2 participants

@Srokap
Srokap commented Mar 29, 2013

I suppose situation below isn't normal? I get DatabaseException on new ElggInstaller() call, before I can even try to run batchInstall.

https://gist.github.com/Srokap/5268479

Started from here: https://github.com/Srokap/Elgg/blob/ticket_5167/install/cli/travis_installer.php

Can it be related to the recent @cash changes in sessions? Seems like problem in installer was always there.

@Srokap
Srokap commented Mar 29, 2013

I've resolved problem in my current work by mockiing session object for installation. Seems to work fine for CLI install. Didn't check for web install.

@cash
cash commented Mar 29, 2013

Problem was definitely not always there. Worked fine in 1.8. Likely is caused by trying to initialize the session without any database tables. Should probably use a file session for the installer.

@Srokap
Srokap commented Mar 30, 2013

I mean, we seemed to always hit $_SESSION when getting languages. Resent session handling rebuild just showed that up.

I'll try to do sth about this file handler.

@cash
cash commented Mar 30, 2013

Ok - I see what you are saying. I think you're right. The CLI mode should inject a mock session handler.

@ewinslow ewinslow closed this in caeeb7f Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.