I suppose situation below isn't normal? I get DatabaseException on new ElggInstaller() call, before I can even try to run batchInstall.
Started from here: https://github.com/Srokap/Elgg/blob/ticket_5167/install/cli/travis_installer.php
Can it be related to the recent @cash changes in sessions? Seems like problem in installer was always there.
I've resolved problem in my current work by mockiing session object for installation. Seems to work fine for CLI install. Didn't check for web install.
Problem was definitely not always there. Worked fine in 1.8. Likely is caused by trying to initialize the session without any database tables. Should probably use a file session for the installer.
I mean, we seemed to always hit $_SESSION when getting languages. Resent session handling rebuild just showed that up.
I'll try to do sth about this file handler.
Ok - I see what you are saying. I think you're right. The CLI mode should inject a mock session handler.
Fixes #5294 - Mocks session for installation process