Make entities default unlikeable #5996

Closed
jdalsem opened this Issue Aug 29, 2013 · 10 comments

Comments

Projects
None yet
7 participants
@jdalsem
Member

jdalsem commented Aug 29, 2013

By default all entities are likeable. It would make more sense to have them not likeable and make them likeable with a canLike hook

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Sep 10, 2013

Member

👍

Evan Winslow
http://community.elgg.org/profile/ewinslow

On Thu, Aug 29, 2013 at 3:22 PM, Jeroen Dalsem notifications@github.comwrote:

By default all entities are likeable. It would make more sense to have
them not likeable and make them likeable with a canLike hook


Reply to this email directly or view it on GitHubhttps://github.com/Elgg/Elgg/issues/5996
.

Member

ewinslow commented Sep 10, 2013

👍

Evan Winslow
http://community.elgg.org/profile/ewinslow

On Thu, Aug 29, 2013 at 3:22 PM, Jeroen Dalsem notifications@github.comwrote:

By default all entities are likeable. It would make more sense to have
them not likeable and make them likeable with a canLike hook


Reply to this email directly or view it on GitHubhttps://github.com/Elgg/Elgg/issues/5996
.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jan 19, 2015

Member

I'm not against this but it's a breaking change and will have to wait for 2.0. We'd also need to implement hooks for content in the bundled plugins.

Member

mrclay commented Jan 19, 2015

I'm not against this but it's a breaking change and will have to wait for 2.0. We'd also need to implement hooks for content in the bundled plugins.

@jdalsem jdalsem added this to the Elgg 2.0.0 milestone Jan 26, 2015

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 1, 2015

feature(likes): entities are not likeable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register a
'permissions_check:annotate' hook to allow like annotations. Core
content plugins have been adjusted to provide these hooks.

fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(likes): Entities are not likable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register your
type/subtype using likes_register_type() in your plugin init function.

Fixes #5996
@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Jul 2, 2015

Contributor

Kind of a pity that this little BC breaking change will require separate releases for 1.X and 2.X for a lot of plugins while ALL the other changes of 2.0 (with exception of making discussions a separate plugins) still allowed to make a single release for 1.X and 2.X.

Contributor

iionly commented Jul 2, 2015

Kind of a pity that this little BC breaking change will require separate releases for 1.X and 2.X for a lot of plugins while ALL the other changes of 2.0 (with exception of making discussions a separate plugins) still allowed to make a single release for 1.X and 2.X.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jul 2, 2015

Member

@iionly thats why it is a breaking change, however, you could still make 1 version that works for both (if this is the only reason), because you can have the same hook registration in 1.x.

Member

jdalsem commented Jul 2, 2015

@iionly thats why it is a breaking change, however, you could still make 1 version that works for both (if this is the only reason), because you can have the same hook registration in 1.x.

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 2, 2015

feature(likes): entities are not likeable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register a
'permissions_check:annotate' hook to allow like annotations. Core
content plugins have been adjusted to provide these hooks.

fixes #5996
@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 2, 2015

Member

But wait of you guard the function call with a conditional to check if it exists, won't that work across 1.x and 2.x?

Member

ewinslow commented Jul 2, 2015

But wait of you guard the function call with a conditional to check if it exists, won't that work across 1.x and 2.x?

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 2, 2015

feature(likes): entities are not likeable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register a
'permissions_check:annotate' hook to allow like annotations. Core
content plugins have been adjusted to provide these hooks.

fixes #5996
@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jul 2, 2015

Member

But wait of you guard the function call with a conditional to check if it exists, won't that work across 1.x and 2.x?

you were talking to @iionly right?

Member

jdalsem commented Jul 2, 2015

But wait of you guard the function call with a conditional to check if it exists, won't that work across 1.x and 2.x?

you were talking to @iionly right?

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 2, 2015

Member

Yea

On Thu, Jul 2, 2015, 6:29 AM Jeroen Dalsem notifications@github.com wrote:

But wait of you guard the function call with a conditional to check if it
exists, won't that work across 1.x and 2.x?

you were talking to @iionly https://github.com/iionly right?


Reply to this email directly or view it on GitHub
#5996 (comment).

Member

ewinslow commented Jul 2, 2015

Yea

On Thu, Jul 2, 2015, 6:29 AM Jeroen Dalsem notifications@github.com wrote:

But wait of you guard the function call with a conditional to check if it
exists, won't that work across 1.x and 2.x?

you were talking to @iionly https://github.com/iionly right?


Reply to this email directly or view it on GitHub
#5996 (comment).

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Jul 2, 2015

Contributor

Well, I've got a little bit frustrated this morning about the last minute BC breaking changes that foiled my plan to have compatible versions of all my plugins ready at about the end of next week allowing me to take a little break to enjoy summer. Now I will have to figure out again which plugins I have to rework again that I thought until yesterday would already be 2.0-ready. And I kind of lost the motivation to do that just now. So, I think I will rather take my break just now not putting me under any pressure anymore with getting the plugins working on 2.0 as soon as possible.

@jdalsem it seemed to me this morning that the alternative approach of Steve would make it over the plugin hook approach. And I was not keen on using function_exist just to have a plugin version that works both on 1.X and 2.X. And even with the plugin hook approach having been selected a new plugin release will be necessary nevertheless. Almost all other BC breaking issues of 2.0 wouldn't require a new plugin release if the plugin is already fully 1.10/1.11 compatible without any deprecation issues and all JS code AMDed (which was basically the only thing I had to work on so far).

Contributor

iionly commented Jul 2, 2015

Well, I've got a little bit frustrated this morning about the last minute BC breaking changes that foiled my plan to have compatible versions of all my plugins ready at about the end of next week allowing me to take a little break to enjoy summer. Now I will have to figure out again which plugins I have to rework again that I thought until yesterday would already be 2.0-ready. And I kind of lost the motivation to do that just now. So, I think I will rather take my break just now not putting me under any pressure anymore with getting the plugins working on 2.0 as soon as possible.

@jdalsem it seemed to me this morning that the alternative approach of Steve would make it over the plugin hook approach. And I was not keen on using function_exist just to have a plugin version that works both on 1.X and 2.X. And even with the plugin hook approach having been selected a new plugin release will be necessary nevertheless. Almost all other BC breaking issues of 2.0 wouldn't require a new plugin release if the plugin is already fully 1.10/1.11 compatible without any deprecation issues and all JS code AMDed (which was basically the only thing I had to work on so far).

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Jul 2, 2015

Contributor

Can't we just remove likes for anything that's not searchable and leave it
be?
On Jul 2, 2015 8:10 PM, "iionly" notifications@github.com wrote:

Well, I've got a little bit frustrated this morning about the last minute
BC breaking changes that foiled my plan to have compatible versions of all
my plugins ready at about the end of next week allowing me to take a little
break to enjoy summer. Now I will have to figure out again which plugins I
have to rework again that I thought until yesterday would already be
2.0-ready. And I kind of lost the motivation to do that just now. So, I
think I will rather take my break just now not putting me under any
pressure anymore with getting the plugins working on 2.0 as soon as
possible.

@jdalsem https://github.com/jdalsem it seemed to me this morning that
the alternative approach of Steve would make it over the plugin hook
approach. And I was not keen on using function_exist just to have a plugin
version that works both on 1.X and 2.X. And even with the plugin hook
approach having been selected a new plugin release will be necessary
nevertheless. Almost all other BC breaking issues of 2.0 wouldn't require a
new plugin release if the plugin is already fully 1.10/1.11 compatible
without any deprecation issues and all JS code AMDed (which was basically
the only thing I had to work on so far).


Reply to this email directly or view it on GitHub
#5996 (comment).

Contributor

hypeJunction commented Jul 2, 2015

Can't we just remove likes for anything that's not searchable and leave it
be?
On Jul 2, 2015 8:10 PM, "iionly" notifications@github.com wrote:

Well, I've got a little bit frustrated this morning about the last minute
BC breaking changes that foiled my plan to have compatible versions of all
my plugins ready at about the end of next week allowing me to take a little
break to enjoy summer. Now I will have to figure out again which plugins I
have to rework again that I thought until yesterday would already be
2.0-ready. And I kind of lost the motivation to do that just now. So, I
think I will rather take my break just now not putting me under any
pressure anymore with getting the plugins working on 2.0 as soon as
possible.

@jdalsem https://github.com/jdalsem it seemed to me this morning that
the alternative approach of Steve would make it over the plugin hook
approach. And I was not keen on using function_exist just to have a plugin
version that works both on 1.X and 2.X. And even with the plugin hook
approach having been selected a new plugin release will be necessary
nevertheless. Almost all other BC breaking issues of 2.0 wouldn't require a
new plugin release if the plugin is already fully 1.10/1.11 compatible
without any deprecation issues and all JS code AMDed (which was basically
the only thing I had to work on so far).


Reply to this email directly or view it on GitHub
#5996 (comment).

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jul 2, 2015

Member

FWIW current work on this feature is in #8654, which should work fine across versions.

Member

mrclay commented Jul 2, 2015

FWIW current work on this feature is in #8654, which should work fine across versions.

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jul 3, 2015

feature(likes): entities are not likeable by default
BREAKING CHANGE:
If you want to allow likes on your content you will have to register a
'permissions_check:annotate' hook to allow like annotations. Core
content plugins have been adjusted to provide these hooks.

fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 6, 2015

feature(likes): Entities are no longer likable by default
BREAKING CHANGE:
To allow likes on your content you must permit the annotation to be created.
Likes provides a new hook “likes:is_likable” to allow easily registering entities
by type:subtype.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 6, 2015

feature(likes): Entities are no longer likable by default
BREAKING CHANGE:
To allow likes on your content you must permit the annotation to be created.
Likes provides a new hook “likes:is_likable” to allow easily registering entities
by type:subtype.

Fixes #5996

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 6, 2015

feature(likes): Entities are no longer likable by default
BREAKING CHANGE:
To allow likes on your content you must permit the annotation to be created.
Likes provides a new hook “likes:is_likable” to allow easily registering entities
by type:subtype.

Fixes #5996

@jdalsem jdalsem closed this in #8701 Jul 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment