New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs should not display the title of the current page #6419

Closed
ewinslow opened this Issue Feb 6, 2014 · 12 comments

Comments

Projects
None yet
9 participants
@ewinslow
Member

ewinslow commented Feb 6, 2014

On the discussion pages I noticed that the title shows up no less than three times right next to each other. The breadcrumbs instance of the title is almost certainly superfluous because its not even clickable.

@sembrestels

This comment has been minimized.

Show comment
Hide comment
@sembrestels
Member

sembrestels commented Feb 8, 2014

+1

@sembrestels sembrestels added the easy label Feb 8, 2014

@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Oct 1, 2014

Member

I like having the unclickable title in the breadcrumbs. It tells you where you are and links how you got there.

Member

beck24 commented Oct 1, 2014

I like having the unclickable title in the breadcrumbs. It tells you where you are and links how you got there.

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Oct 2, 2014

Member

The point here is that you already know where you are because that information exists on the page already.

Member

ewinslow commented Oct 2, 2014

The point here is that you already know where you are because that information exists on the page already.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 2, 2014

Member

Breadcrumbs are opinionated. I suggest we pass the array through a plugin hook before rendering to make editing them easier.

Member

mrclay commented Oct 2, 2014

Breadcrumbs are opinionated. I suggest we pass the array through a plugin hook before rendering to make editing them easier.

@brettp

This comment has been minimized.

Show comment
Hide comment
@brettp

brettp Oct 2, 2014

Member

+1 for plugin hook

On Thu, Oct 2, 2014 at 3:03 PM, Steve Clay notifications@github.com wrote:

Breadcrumbs are opinionated. I suggest we pass the array through a plugin
hook before rendering to make editing them easier.


Reply to this email directly or view it on GitHub
#6419 (comment).

Brett Profitt
Elgg Lead Developer

Elgg: http://elgg.org/
Skype: brett.profitt
Twitter: http://twitter.com/brettprofitt

Member

brettp commented Oct 2, 2014

+1 for plugin hook

On Thu, Oct 2, 2014 at 3:03 PM, Steve Clay notifications@github.com wrote:

Breadcrumbs are opinionated. I suggest we pass the array through a plugin
hook before rendering to make editing them easier.


Reply to this email directly or view it on GitHub
#6419 (comment).

Brett Profitt
Elgg Lead Developer

Elgg: http://elgg.org/
Skype: brett.profitt
Twitter: http://twitter.com/brettprofitt

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Oct 2, 2014

Contributor

Why not use the menu system?

Contributor

hypeJunction commented Oct 2, 2014

Why not use the menu system?

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 3, 2014

Member

Could we make the elgg breadcrumb functions build a menu?

Member

mrclay commented Oct 3, 2014

Could we make the elgg breadcrumb functions build a menu?

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Oct 3, 2014

Member

Issue about using the menu system: #3428

Member

juho-jaakkola commented Oct 3, 2014

Issue about using the menu system: #3428

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 3, 2014

Member

I think the former consensus was that the ROI for conversion to menu was low (and I guess would cost us more time in creating new bugs).

Member

mrclay commented Oct 3, 2014

I think the former consensus was that the ROI for conversion to menu was low (and I guess would cost us more time in creating new bugs).

@mrclay mrclay self-assigned this Oct 3, 2014

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Oct 3, 2014

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 3, 2014

Member

See #7262

Member

mrclay commented Oct 3, 2014

See #7262

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Oct 3, 2014

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Nov 30, 2014

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 3, 2014

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

@Srokap Srokap added the in progress label Dec 3, 2014

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 4, 2014

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 19, 2015

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 27, 2015

feature(navigation): add hook to filter breadcrumbs
This also makes sure crumb titles are escaped in the view, and moves the
elgg_get_excerpt call to a hook handler, allowing it to be disabled.

Fixes #6419

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 27, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 27, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Jan 27, 2015

PR #7830

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 27, 2015

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Feb 3, 2015

Member

@mrclay i believe this ticket can be closed because of the merge am i right?

Member

jdalsem commented Feb 3, 2015

@mrclay i believe this ticket can be closed because of the merge am i right?

@mrclay mrclay closed this Feb 3, 2015

@Srokap Srokap removed the in progress label Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment