Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links while editing a comment #6666

Closed
teamwebgalli opened this issue Mar 24, 2014 · 5 comments
Closed

Broken links while editing a comment #6666

teamwebgalli opened this issue Mar 24, 2014 · 5 comments
Assignees
@Srokap
Labels
bug easy engine
Milestone
Elgg 1.9.0 Releas...

Comments

@teamwebgalli
Copy link
Contributor

comments

The links for editing the comments are returning soft 404 pages, if they are opened in new tabs / windows. Please see the screenshot.

The toggling of the comment edit form wont work (instead it opens the 404 page), if we have a duplicate comment listed on the same page. - Created a separate ticket for this #6667
@Srokap
Copy link
Contributor

Srokap commented Mar 24, 2014

Version?

@teamwebgalli
Copy link
Contributor Author

Upcoming release V1.9 from github

@Srokap
Copy link
Contributor

Srokap commented Mar 24, 2014

Ok, confirmed. We have this case handled only for group discussion replies, but not for generic comments. Need to implement comment/edit/COMMENT_GUID page handler in simillar way as discussion/reply/edit/COMMENT_GUID

@Srokap Srokap added this to the Elgg 1.9.0 Release Candidate milestone Mar 24, 2014
@Srokap Srokap mentioned this issue Mar 24, 2014
Closed
@ewinslow
Copy link
Contributor

@teamwebgalli @Srokap either of you want to own this?

@Srokap Srokap self-assigned this Apr 12, 2014
@Srokap
Copy link
Contributor

Srokap commented Apr 12, 2014

I did current form, I'll take it.

Srokap added a commit to Srokap/Elgg that referenced this issue Apr 13, 2014
@Srokap
feature(comments): Added separate edit page for generic comments.php
d45e00a 
That handles case when user opens edit link in new tab.

Fixes Elgg#6666
Srokap added a commit to Srokap/Elgg that referenced this issue Apr 13, 2014
@Srokap
feature(comments): Added separate edit page for generic comments.php
bda24e3 
That handles case when user opens edit link in new tab.

Fixes Elgg#6666
@Srokap Srokap mentioned this issue Apr 13, 2014
Closed
2 tasks
Srokap added a commit to Srokap/Elgg that referenced this issue Apr 13, 2014
@Srokap
feature(comments): Added separate edit page for generic comments
ad20ab7 
That handles case when user opens edit link in new tab.

Fixes Elgg#6666
@Srokap Srokap closed this as completed in a5c73b6 Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Srokap Srokap

Labels
bug easy engine
Milestone
Elgg 1.9.0 Release Candidate
Development

No branches or pull requests
3 participants
@ewinslow @teamwebgalli @Srokap