New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestorename of files uploaded using file plugin are not kept updated #6677

Closed
propertunist opened this Issue Mar 30, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@propertunist

propertunist commented Mar 30, 2014

  1. upload a file via the file plugin. (i am testing with video files - flv and mp4)
  2. edit the elgg file object and upload a different file to the previously created file object.

examining the filestore directory, shows that the 2nd uploaded file is stored with the file name of the 1st file..
so if i upload xyz.flv and then replace it with xyz.mpg.. the file that is on the hard drive is still called xyz.flv even though it is an mpg.

besides that this is confusing when looking manually at the filestore - this may also cause problems when performing operations on filestore files - as i am currently, to generate video thumbnails.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Apr 4, 2016

fix(file): better uploaded file handling and thumbnail serving
Uploaded files now always have a new name with the client-given extension,
even when replacing a previous upload. Thumbnails files now have the `.jpg`
extension and are served with the `image/jpeg` Content-Type.

Fixes #9612
Fixes #9267
Fixes #6677
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Apr 4, 2016

PR #9615

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Apr 4, 2016

fix(file): better uploaded file handling and thumbnail serving
Uploaded files now always have a new name with the client-given extension,
even when replacing a previous upload. Thumbnails files now have the `.jpg`
extension and are served with the `image/jpeg` Content-Type.

Fixes #9612
Fixes #9267
Fixes #6677

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Apr 4, 2016

fix(file): better uploaded file handling and thumbnail serving
Uploaded files now always have a new name with the client-given extension,
even when replacing a previous upload. Thumbnails files now have the `.jpg`
extension and are served with the `image/jpeg` Content-Type.

If the file is recognized as an image, but thumbnails can't be created, we
no longer allow thumbs from the previous file to be re-used.

Fixes #9612
Fixes #9267
Fixes #6677

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Apr 4, 2016

fix(file): better uploaded file handling and thumbnail serving
Uploaded files now always have a new name with the client-given extension,
even when replacing a previous upload.

Thumbnail JPEG files now have the `.jpg` extension and are served with the
correct Content-Type. If a plugin happened to have created their own non-JPEG
thumbs, they'd now be served with the correct MIME (instead of the original
file's MIME type).

If the file is recognized as an image, but thumbnails can't be created, we
no longer allow thumbs from the previous file to be re-used.

Fixes #9612
Fixes #9267
Fixes #6677

@jeabakker jeabakker removed their assignment Apr 5, 2016

@mrclay mrclay closed this in 72140cf Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment