Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft_min_word_len and ft_max_word_len #6707

Closed
hypeJunction opened this issue Apr 11, 2014 · 4 comments

Comments

@hypeJunction
Copy link
Contributor

commented Apr 11, 2014

The search plugin hits the database on each page load to retrieve ft_min_word_len and ft_max_word_len. Shouldn't we just write it to settings on install? Seems like a costly operation for a constant value.

@mrclay

This comment has been minimized.

Copy link
Member

commented Apr 11, 2014

Add function search_get_ft_min_max(), which would cache to elgg_get_system_cache().

@ewinslow

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

I'm open to either config values or cache. If set in config, definitely ignore db.

@ewinslow

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

FWIW, this will be a much easier pattern to support once we move to PHP-DI

@jdalsem

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

i am fine with the suggested change... can you submit a PR @hypeJunction ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.