New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elgg_Database::getResults ignores bad callbacks #6937

Closed
mrclay opened this Issue Jun 19, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@mrclay
Member

mrclay commented Jun 19, 2014

If $callback is not empty but isn't callable, that seems like a concern worth raising. Instead the function just doesn't call it.

@mrclay mrclay added bug labels Jun 19, 2014

@ewinslow ewinslow added this to the Elgg 2.0.x milestone Feb 27, 2015

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Feb 27, 2015

Member

We should throw exceptions for stuff like this...

Member

ewinslow commented Feb 27, 2015

We should throw exceptions for stuff like this...

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Feb 27, 2015

Contributor

Exception please. When I use a custom callback, I usually expect a certain behavior from anentity afterwards.

Contributor

hypeJunction commented Feb 27, 2015

Exception please. When I use a custom callback, I usually expect a certain behavior from anentity afterwards.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Apr 10, 2015

PR #8155

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Apr 10, 2015

@mrclay mrclay closed this in #8155 Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment