Define widget layout container explicitly #7023

Closed
hypeJunction opened this Issue Jul 9, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@hypeJunction
Contributor

hypeJunction commented Jul 9, 2014

It is currently assumed that the page owner is the containing entity for widget layouts. I would like to add a 'data-guid' attribute and allow containers to be passed explicitly to the widget layout with a fallback to page owner. Thoughts?

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 9, 2014

Member

SGTM. Maybe data-container instead? or data-container-guid?

Member

ewinslow commented Jul 9, 2014

SGTM. Maybe data-container instead? or data-container-guid?

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Jul 9, 2014

Contributor

Either way :)

Contributor

hypeJunction commented Jul 9, 2014

Either way :)

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 9, 2014

Member

Just want to be explicit about which GUID we're talking about.

Member

ewinslow commented Jul 9, 2014

Just want to be explicit about which GUID we're talking about.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Oct 20, 2014

Member

@hypeJunction do you want to pass this to the add panel?

Member

jdalsem commented Oct 20, 2014

@hypeJunction do you want to pass this to the add panel?

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Oct 20, 2014

Contributor

to the widgets layout, all containing elements can get it using $.closest()

Contributor

hypeJunction commented Oct 20, 2014

to the widgets layout, all containing elements can get it using $.closest()

@jdalsem jdalsem self-assigned this Feb 23, 2015

@ManUtopiK

This comment has been minimized.

Show comment
Hide comment
@ManUtopiK

ManUtopiK Mar 5, 2015

Contributor

I think this feature will also resolve issue #6595.

Contributor

ManUtopiK commented Mar 5, 2015

I think this feature will also resolve issue #6595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment