New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ckeditor config array through a hook #7131

Closed
mrclay opened this Issue Aug 1, 2014 · 9 comments

Comments

Projects
None yet
4 participants
@mrclay
Member

mrclay commented Aug 1, 2014

Would be nice to alter bits of this without replacing the whole view.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 13, 2015

Member

Seems to be blocked by #7926.

Member

mrclay commented Feb 13, 2015

Seems to be blocked by #7926.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Feb 13, 2015

Member

We could also close this because it is easy to override the config view

Member

jdalsem commented Feb 13, 2015

We could also close this because it is easy to override the config view

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 18, 2015

Contributor

@jdalsem I think just overriding a view is not the ideal solution, since there may be several plugins trying to alter the config.

Contributor

hypeJunction commented Mar 18, 2015

@jdalsem I think just overriding a view is not the ideal solution, since there may be several plugins trying to alter the config.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Mar 18, 2015

Member

agree, that is why i made #7896, however that was not accepted because of race condition in AMD modules. Alternatively we could change the view to merge $vars['ckeditor_config'] with local defaults. That way you can influence the config from multiple plugins by hooking on the view and change the vars...

Member

jdalsem commented Mar 18, 2015

agree, that is why i made #7896, however that was not accepted because of race condition in AMD modules. Alternatively we could change the view to merge $vars['ckeditor_config'] with local defaults. That way you can influence the config from multiple plugins by hooking on the view and change the vars...

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 18, 2015

Member

@hypeJunction Maybe give #7926 a look.

Member

mrclay commented Mar 18, 2015

@hypeJunction Maybe give #7926 a look.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 18, 2015

Contributor

Hm, ckeditor is already extremely slow, having it wait for everything else to load seems like a major performance blow.
Perhaps ckeditor/init should wait for $(document).ready(); and in the meantime elgg.config.ckeditor could be manipulated by plugins?

Contributor

hypeJunction commented Mar 18, 2015

Hm, ckeditor is already extremely slow, having it wait for everything else to load seems like a major performance blow.
Perhaps ckeditor/init should wait for $(document).ready(); and in the meantime elgg.config.ckeditor could be manipulated by plugins?

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 18, 2015

Contributor

I guess I am contradicting myself :)

Contributor

hypeJunction commented Mar 18, 2015

I guess I am contradicting myself :)

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 18, 2015

Member

I have a solution for this, but can't quite get it working: #8080

Member

mrclay commented Mar 18, 2015

I have a solution for this, but can't quite get it working: #8080

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Mar 18, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 19, 2015

Member

Working solution here #8085

Member

mrclay commented Mar 19, 2015

Working solution here #8085

@Srokap Srokap removed the in progress label Apr 10, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 7, 2015

feature(js): adds plugin boot modules and modules based on system events
To reduce race conditions, plugins can create boot modules, named like
`boot/<plugin_id>`. All these modules are loaded before the `init, system`
hook. Registering for plugin hooks should be done inside these.

Depending on the new `elgg/init` module ensures your code runs after this
process.

Similarly, you can depend on the new `elgg/ready` module to ensure all ready
hooks have been called.

Plugin boot modules return an instance of `elgg/Plugin`.

A new hook `config, ckeditor` now filters the CKEditor config object, and
plugins can reliably register for it in a boot module.

Fixes #7131
Fixes #7926

@mrclay mrclay closed this in #8996 Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment