New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with private API stuff still needed by plugins #7838

Closed
mrclay opened this Issue Jan 29, 2015 · 9 comments

Comments

Projects
None yet
6 participants
@mrclay
Member

mrclay commented Jan 29, 2015

Source:

  • Make public elgg_view_entity_list (#7826),
  • Make public get_subtype_class,
  • Make public get_subtype_id,
  • Make public access_get_show_hidden_status,
  • Make public access_show_hidden_entities,
  • Make public version of _elgg_html_decode,
  • Consider what to do about elgg_get_upgrade_file_version,
  • Consider what to do about generate_action_token,
  • Consider what to do about _elgg_services()->hooks->getOrderedHandlers().

cc @iionly

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jan 29, 2015

Member

can we also add public helper functions for: _elgg_services()->db->enableQueryCache() and disableQueryCache()?

Member

jdalsem commented Jan 29, 2015

can we also add public helper functions for: _elgg_services()->db->enableQueryCache() and disableQueryCache()?

@jdalsem jdalsem added this to the Elgg 1.11 milestone Feb 4, 2015

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Feb 4, 2015

Member

assigned to 1.11 as i would like to give clarity to devs about the usage of the functions.

Member

jdalsem commented Feb 4, 2015

assigned to 1.11 as i would like to give clarity to devs about the usage of the functions.

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Apr 13, 2015

Contributor

Bummer! Now Elgg 1.11 got released without the clarification on the future of these private functions.

How about you simply vote on it to get this matter sorted out? It would really, really be quite helpful to know what will be decided. And I think it should even be possible to make these functions public (again) in a bugfix release (the sooner the better) as there wouldn't be any changes in functionality.

Contributor

iionly commented Apr 13, 2015

Bummer! Now Elgg 1.11 got released without the clarification on the future of these private functions.

How about you simply vote on it to get this matter sorted out? It would really, really be quite helpful to know what will be decided. And I think it should even be possible to make these functions public (again) in a bugfix release (the sooner the better) as there wouldn't be any changes in functionality.

@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Apr 13, 2015

Member

d'oh, I guess this got overlooked. I vote to make them public, I've needed to use almost all of the listed functions in plugins.

Member

beck24 commented Apr 13, 2015

d'oh, I guess this got overlooked. I vote to make them public, I've needed to use almost all of the listed functions in plugins.

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Apr 17, 2015

Member

making them public sounds fine with me.

Member

ewinslow commented Apr 17, 2015

making them public sounds fine with me.

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Jul 14, 2015

Contributor

@Elgg/owners wouldn't it be good to decide on how to proceed with these functions for example before the final 2.0 is out?

Contributor

iionly commented Jul 14, 2015

@Elgg/owners wouldn't it be good to decide on how to proceed with these functions for example before the final 2.0 is out?

@mrclay mrclay added this to the Elgg 2.0.x milestone Jul 14, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 30, 2015

chore(core): Makes several commonly-used functions public
This also adds elgg_enable_query_cache, elgg_disable_query_cache, and
elgg_html_decode.

Fixes #7838
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Jul 30, 2015

PR #8766

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 30, 2015

feature(core): Makes several commonly-used functions public
This also adds elgg_enable_query_cache, elgg_disable_query_cache, and
elgg_html_decode.

Fixes #7838

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 30, 2015

feature(core): Makes several commonly-used functions public
This also adds elgg_enable_query_cache, elgg_disable_query_cache, and
elgg_html_decode.

Fixes #7838

@mrclay mrclay closed this in #8766 Jul 30, 2015

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Jul 30, 2015

Contributor

Has elgg_view_entity_list() been forgotten? Issue #7826 has been closed with reference to this issue here but now the PR does not deal with it.

Contributor

iionly commented Jul 30, 2015

Has elgg_view_entity_list() been forgotten? Issue #7826 has been closed with reference to this issue here but now the PR does not deal with it.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jul 31, 2015

Member

elgg_view_entity_list() has not been forgotten https://github.com/Elgg/Elgg/pull/8766/files#r35903761

Member

jdalsem commented Jul 31, 2015

elgg_view_entity_list() has not been forgotten https://github.com/Elgg/Elgg/pull/8766/files#r35903761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment