New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_views should be bundled if web_services is bundled #8053

Closed
brettp opened this Issue Mar 10, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@brettp
Member

brettp commented Mar 10, 2015

This just bit me. Bundling the web_services plugin for BC is less effective if the data_views plugin isn't also bundled. The only included views are JSON. Missing XML views breaks BC and also makes the docs worthless: http://learn.elgg.org/en/1.10/guides/web-services.html#response-formats

Refs #5034

@brettp brettp added the bc break label Mar 10, 2015

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Mar 10, 2015

Member

mmm.... indeed. I'd be fine with adding them back with composer. Pretty
low-cost fix...

On Tue, Mar 10, 2015 at 11:52 AM Brett Profitt notifications@github.com
wrote:

This just bit me. Bundling the web_services plugin for BC is less
effective if the data_views plugin isn't also bundled. The only included
views are JSON. Missing XML views breaks BC and also makes the docs
worthless:
http://learn.elgg.org/en/1.10/guides/web-services.html#response-formats

Refs #5034 #5034


Reply to this email directly or view it on GitHub
#8053.

Member

ewinslow commented Mar 10, 2015

mmm.... indeed. I'd be fine with adding them back with composer. Pretty
low-cost fix...

On Tue, Mar 10, 2015 at 11:52 AM Brett Profitt notifications@github.com
wrote:

This just bit me. Bundling the web_services plugin for BC is less
effective if the data_views plugin isn't also bundled. The only included
views are JSON. Missing XML views breaks BC and also makes the docs
worthless:
http://learn.elgg.org/en/1.10/guides/web-services.html#response-formats

Refs #5034 #5034


Reply to this email directly or view it on GitHub
#8053.

@brettp

This comment has been minimized.

Show comment
Hide comment
Member

brettp commented Apr 1, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Apr 29, 2015

Member

Strawman: copy the function into data_views as data_views_object_to_xml(). Allows us to keep the core one deprecated.

Member

mrclay commented Apr 29, 2015

Strawman: copy the function into data_views as data_views_object_to_xml(). Allows us to keep the core one deprecated.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 22, 2016

fix(web_services): web services again can output xml/php
Pulls in data_views via composer.
Updates docs to indicate only JSON works by default.

Fixes #8053

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 22, 2016

fix(web_services): web services again can output xml/php
Pulls in data_views via composer.
Updates docs to indicate only JSON works by default.

Fixes #8053
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 24, 2016

Member

Fixed by #9409

Member

mrclay commented Feb 24, 2016

Fixed by #9409

@mrclay mrclay closed this Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment