New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward to comment after posting it #8130

Closed
juho-jaakkola opened this Issue Apr 10, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@juho-jaakkola
Member

juho-jaakkola commented Apr 10, 2015

Currently user is taken by default to the commented object after posting a comment:

forward(REFERER);

Couldn't we just always forward to the comment itself:
https://github.com/Elgg/Elgg/blob/master/actions/comment/save.php#L95

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Apr 10, 2015

Member

It seems we could get rid of the is_edit_page variable completely. https://github.com/Elgg/Elgg/search?utf8=%E2%9C%93&q=is_edit_page

Member

juho-jaakkola commented Apr 10, 2015

It seems we could get rid of the is_edit_page variable completely. https://github.com/Elgg/Elgg/search?utf8=%E2%9C%93&q=is_edit_page

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Apr 10, 2015

Member

Seems logical, are there usecases where there is something special? Like commenting on something but not on the form attached to the object? Like from the activity stream (although that currently is tackled because it is an ajax call)

Member

jdalsem commented Apr 10, 2015

Seems logical, are there usecases where there is something special? Like commenting on something but not on the form attached to the object? Like from the activity stream (although that currently is tackled because it is an ajax call)

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Apr 10, 2015

Member

Is the action also used for edits? Those are also sometimes inline...

Member

jdalsem commented Apr 10, 2015

Is the action also used for edits? Those are also sometimes inline...

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Apr 10, 2015

Member

I cannot think of any use case where we could not forward to the comment itself.

Member

juho-jaakkola commented Apr 10, 2015

I cannot think of any use case where we could not forward to the comment itself.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Apr 10, 2015

Member

I cannot think of any use case where we could not forward to the comment itself.

me neither... besides the ajaxed save actions i mentioned before

Member

jdalsem commented Apr 10, 2015

I cannot think of any use case where we could not forward to the comment itself.

me neither... besides the ajaxed save actions i mentioned before

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Apr 10, 2015

Member

But we're not using forwarding at all when the comment is saved using ajax, right?

Member

juho-jaakkola commented Apr 10, 2015

But we're not using forwarding at all when the comment is saved using ajax, right?

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Apr 10, 2015

Member

hmm i noticed commenting on the river is not ajax (i thought it was), thus we still need REFERER

Member

jdalsem commented Apr 10, 2015

hmm i noticed commenting on the river is not ajax (i thought it was), thus we still need REFERER

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Apr 10, 2015

Member

Quick fix would be to allow passing in the referer URL as a parameter. The comment URL would be used unless explicitly told to do forward somewhere else.

Member

juho-jaakkola commented Apr 10, 2015

Quick fix would be to allow passing in the referer URL as a parameter. The comment URL would be used unless explicitly told to do forward somewhere else.

@jdalsem jdalsem changed the title from Forward to commend after posting it to Forward to comment after posting it Apr 10, 2015

@juho-jaakkola juho-jaakkola modified the milestones: 1.12.x, Elgg 1.11.x Apr 13, 2015

@mrclay mrclay modified the milestones: Elgg 2.0.x, Elgg 1.12.x Jan 26, 2016

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Mar 4, 2016

fix(comments): unifies behavior after adding new comment/discussion r…
…eply

We forward to either the comment/reply URL or to the activity page if it
was posted from there.

If returning to the activity page, the new comment/reply is jumped to and
highlighted as it would be on the object/topic page.

Fixes #8130
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Mar 4, 2016

PR #9441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment