New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions should validate access level on registration #8337

Closed
mrclay opened this Issue May 20, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@mrclay
Member

mrclay commented May 20, 2015

E.g. the level "Admin" is silently treated as "logged_in".

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay May 20, 2015

Member

Probably best for unrecognized values to be treated as "admin"

Member

mrclay commented May 20, 2015

Probably best for unrecognized values to be treated as "admin"

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction May 20, 2015

Contributor

It would be nice to have constants for that to avoid typos

Contributor

hypeJunction commented May 20, 2015

It would be nice to have constants for that to avoid typos

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue May 31, 2015

fix(actions): Misspelled action levels no longer treated as logged_in.
Instead we now log an error and set the level to “admin”

Fixes #8337
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented May 31, 2015

PR #8398

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 1, 2015

fix(actions): Misspelled action levels no longer treated as logged_in.
Instead we now log an error and set the level to “admin”

Fixes #8337

@mrclay mrclay closed this in #8398 Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment