New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for register, user hook #8377

Closed
SirbitoX opened this Issue May 28, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@SirbitoX

SirbitoX commented May 28, 2015

From the documentation "register, user" hook:

Triggered after user registers. Return false to delete the user.

So, it is expected that this hook triggered in register_user($username, $password, $name, $email, $allow_multiple_emails = false) function and after registering the user successfully. Or at least this function should triggers another hook if the usage of "register, user" is different. This helps developers use this hook every where that register_user is called (register action, adduser action and etc).

@mrclay

This comment has been minimized.

Member

mrclay commented May 28, 2015

The docs should specify that the hook is triggered by the register action, not by the function.

Aside: You can cancel inside the function using the create, user event.

@mrclay mrclay changed the title from The hook of register, user to Clarify docs for register, user hook May 28, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 2, 2015

@jdalsem jdalsem closed this Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment