New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull ColdTrick/plugin_manager improvements into core #8412

Closed
mrclay opened this Issue Jun 4, 2015 · 8 comments

Comments

Projects
None yet
4 participants
@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Jun 4, 2015

Member

I believe this has been discussed and voted on before. I was in favor, but we were outvoted by people opposed (I don't even remember the arguments against...)

Member

beck24 commented Jun 4, 2015

I believe this has been discussed and voted on before. I was in favor, but we were outvoted by people opposed (I don't even remember the arguments against...)

@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Jun 4, 2015

Member

ah, I was thinking of this thread: #3148

Member

beck24 commented Jun 4, 2015

ah, I was thinking of this thread: #3148

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 4, 2015

Member

Only suggestion would be remove the check icons and add an explicit [Enable]/[Disabled] button on the right. Toggling a plugin's state is an important operation that should look like taking a big action.

Member

mrclay commented Jun 4, 2015

Only suggestion would be remove the check icons and add an explicit [Enable]/[Disabled] button on the right. Toggling a plugin's state is an important operation that should look like taking a big action.

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jun 4, 2015

Member

Agreed that pulling that stuff in would be a net improvement. Perhaps the Coldtrick guys would like to submit a PR?

Member

ewinslow commented Jun 4, 2015

Agreed that pulling that stuff in would be a net improvement. Perhaps the Coldtrick guys would like to submit a PR?

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 4, 2015

Member

This would be good work for new-to-Elgg devs to dip their feet into.

Member

mrclay commented Jun 4, 2015

This would be good work for new-to-Elgg devs to dip their feet into.

@mrclay mrclay added the easy label Jun 4, 2015

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jun 5, 2015

Member

i assume you do not want to pull this in via composer but just replace the current core plugin management features with the features of the plugin_manager plugin am i right? That may be not that easy for new devs, but i am willing to take this, so i am assigning it to me.

Member

jdalsem commented Jun 5, 2015

i assume you do not want to pull this in via composer but just replace the current core plugin management features with the features of the plugin_manager plugin am i right? That may be not that easy for new devs, but i am willing to take this, so i am assigning it to me.

@jdalsem jdalsem self-assigned this Jun 5, 2015

@jdalsem jdalsem added this to the Elgg 2.0.x milestone Jun 5, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 5, 2015

Member

Does the plugin work at any priority, ie doesn't override stuff from other plugins? It would be useful for core to be able to support "core" plugins that not only ship with Elgg but behave more like core functionality (can't be disabled, always starts before other plugins). I vaguely remember hearing this is how functionality is added to WordPress now.

Member

mrclay commented Jun 5, 2015

Does the plugin work at any priority, ie doesn't override stuff from other plugins? It would be useful for core to be able to support "core" plugins that not only ship with Elgg but behave more like core functionality (can't be disabled, always starts before other plugins). I vaguely remember hearing this is how functionality is added to WordPress now.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 5, 2015

Member

...ideally we could pull plugins in as a part of core and just remove the stuff they override.

Member

mrclay commented Jun 5, 2015

...ideally we could pull plugins in as a part of core and just remove the stuff they override.

jdalsem added a commit to jdalsem/Elgg that referenced this issue Jun 19, 2015

@jdalsem jdalsem referenced this issue Jun 19, 2015

Closed

feature(plugins): improved plugin listing #8528

0 of 3 tasks complete

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 25, 2015

feature(plugins): Improved plugin listing
Fixes #8412
Fixes #4158
Fixes #4301
Fixes #6778

BREAKING CHANGE:
The plugin views are redesigned to display in a lightbox. This completely
removes the views forms/admin/plugins/filter and forms/admin/plugins/sort.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 29, 2015

feature(plugins): Improved plugin listing
Fixes #8412
Fixes #4158
Fixes #4301
Fixes #6778

BREAKING CHANGE:
The plugin views are redesigned to display in a lightbox. This completely
removes the views forms/admin/plugins/filter and forms/admin/plugins/sort.

@mrclay mrclay closed this in #8588 Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment