New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elgg_get_viewtype() checks get_input('view') for every view #8438

Closed
mrclay opened this Issue Jun 9, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@mrclay
Member

mrclay commented Jun 9, 2015

Boot should sniff input once and set $CURRENT_SYSTEM_VIEWTYPE accordingly, and users should use elgg_set_viewtype() for changing it.

We should remove the test that makes sure set_input('view') has an effect on viewtype.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 9, 2015

Member

@ewinslow this could help offset perf costs in your views overhaul

Member

mrclay commented Jun 9, 2015

@ewinslow this could help offset perf costs in your views overhaul

@ewinslow ewinslow added this to the Elgg 2.0.x milestone Jun 12, 2015

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jul 1, 2015

Member

PR was already made before... #7908

Member

jdalsem commented Jul 1, 2015

PR was already made before... #7908

@mrclay mrclay added the important label Jul 1, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jul 1, 2015

Member

@jdalsem Let me know if you don't have time to work on this. I'm happy to get this in.

Member

mrclay commented Jul 1, 2015

@jdalsem Let me know if you don't have time to work on this. I'm happy to get this in.

@mrclay mrclay self-assigned this Jul 2, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 2, 2015

perf(engine): Viewtype is auto-detected only once
BREAKING CHANGE:
Elgg no longer checks get_input(‘view’) and $CONFIG->view for every call
of elgg_get_viewtype(). elgg_set_viewtype() must be used to change the
global viewtype.

Fixes #8438
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jul 2, 2015

Member

master PR #8663

Member

mrclay commented Jul 2, 2015

master PR #8663

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 2, 2015

perf(engine): Viewtype is auto-detected only once
BREAKING CHANGE:
Elgg no longer checks get_input(‘view’) and $CONFIG->view for every call
of elgg_get_viewtype(). elgg_set_viewtype() must be used to change the
global viewtype.

Fixes #8438

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 2, 2015

perf(engine): Viewtype is auto-detected only once
BREAKING CHANGE:
Elgg no longer checks get_input(‘view’) and $CONFIG->view for every call
of elgg_get_viewtype(). elgg_set_viewtype() must be used to change the
global viewtype.

Fixes #8438

@ewinslow ewinslow closed this in #8663 Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment