New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: jquery-ui must be fully synchronous #8515

Closed
mrclay opened this Issue Jun 18, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@mrclay
Member

mrclay commented Jun 18, 2015

The solution in #8484 does not cut it (try the forms theme_sandbox page). We need UI's factory function to run fully synchronously. This seems to work:

<?php
$js = file_get_contents(elgg_get_root_path() . "/vendor/bower-asset/jquery-ui/jquery-ui.min.js");

// We must hide define() from jQuery UI in order to reliably run its factory
// function synchronously. If we let it define(), require() does not block and
// allows other scripts to run code before $.ui is available.
?>
//<script>
!function(define) {
    <?= $js ?>
}();
define('jquery-ui', null);

@mrclay mrclay added this to the Elgg 2.0.x milestone Jun 18, 2015

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 18, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes Elgg#6844
Fixes Elgg#8515

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 18, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes Elgg#6844
Fixes Elgg#8515

@mrclay mrclay changed the title from jquery-ui must be fully synchronous to master: jquery-ui must be fully synchronous Jun 18, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 18, 2015

Member

This fix is in #8513.

Member

mrclay commented Jun 18, 2015

This fix is in #8513.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 20, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes Elgg#6844
Fixes Elgg#8515

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 20, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes Elgg#6844
Fixes Elgg#8515
Fixes Elgg#8527

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 20, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes Elgg#6844
Fixes Elgg#8515
Fixes Elgg#8527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment