New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elgg_get_view_location() in 2.0 #8527

Closed
mrclay opened this Issue Jun 19, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@mrclay
Member

mrclay commented Jun 19, 2015

Not used in core, and I don't see a use case that would be wise. It doesn't check file existence, and if views are set via mod/plugin/views.php (#8513), it can't return a usable path for those.

A views/ path is just no longer a useful shorthand for the exact location of a view file.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 19, 2015

Member

elgg_get_view_location() could be left in. We could also expose the exact view file location to plugins, if that would be valuable.

The only case I can imagine is a plugin detecting if another plugin "won" the view and overriding it before render.

Member

mrclay commented Jun 19, 2015

elgg_get_view_location() could be left in. We could also expose the exact view file location to plugins, if that would be valuable.

The only case I can imagine is a plugin detecting if another plugin "won" the view and overriding it before render.

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jun 19, 2015

Member

Agree removing it seems like the best option.

Member

ewinslow commented Jun 19, 2015

Agree removing it seems like the best option.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jun 19, 2015

Member

in none of our plugins we use this, so remove it

Member

jdalsem commented Jun 19, 2015

in none of our plugins we use this, so remove it

ewinslow added a commit to ewinslow/Elgg that referenced this issue Jun 19, 2015

deprecate(views): elgg_get_view_location is going away in 2.0
It doesn't seem to have a valid use-case and is making some
views work more difficult than it needs to be.

Refs #8527

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 20, 2015

feature(views): Allow specifying exact view paths via views.php
We use this feature to bring vendor(s) files into the views system.
This also loads jQuery UI completely asynchronously.

Fixes #6844
Fixes #8515
Fixes #8527

@mrclay mrclay closed this in f3881cf Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment