New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/guides/upgrading docs for #8578 #8625

Closed
mrclay opened this Issue Jun 30, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@mrclay
Member

mrclay commented Jun 30, 2015

#8578 removed a bunch of CSS classes. Maybe we don't need to list them all, but theme plugin authors will surely need some heads up.

@mrclay mrclay added this to the Elgg 2.0.x milestone Jun 30, 2015

@mrclay mrclay referenced this issue Jun 30, 2015

Merged

Fontawesome support #8578

3 of 3 tasks complete
@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Jun 30, 2015

Member

Isn't that why it is mentioned in the breaking change commit message? Or should we mention a global "be adviced... a lot of css has been changed, but mainly icons" somewhere in the upgrade docs

Member

jdalsem commented Jun 30, 2015

Isn't that why it is mentioned in the breaking change commit message? Or should we mention a global "be adviced... a lot of css has been changed, but mainly icons" somewhere in the upgrade docs

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jun 30, 2015

Member

@jdalsem We have been duplicating breaking changes between the commit message and the RST upgrade guide. It's a bit annoying, but it does allow us to glom several related breaking changes together like removed views, removed actions, etc.

Also, sometimes the fix for past breaking changes are superceded by future breaking changes. These need to be retroactively updated, which isn't possible to do with commit messages.

Member

ewinslow commented Jun 30, 2015

@jdalsem We have been duplicating breaking changes between the commit message and the RST upgrade guide. It's a bit annoying, but it does allow us to glom several related breaking changes together like removed views, removed actions, etc.

Also, sometimes the fix for past breaking changes are superceded by future breaking changes. These need to be retroactively updated, which isn't possible to do with commit messages.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jun 30, 2015

Member

Slightly diff audiences, too: the upgrading guide should be geared toward helping devs update plugins, the commit message notices don't need as much detail IMO. We need some documented guidelines here.

Member

mrclay commented Jun 30, 2015

Slightly diff audiences, too: the upgrading guide should be geared toward helping devs update plugins, the commit message notices don't need as much detail IMO. We need some documented guidelines here.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Jul 2, 2015

PR #8662

@ewinslow ewinslow closed this in #8662 Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment