New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: Can't use Application without full booting #8653

Closed
mrclay opened this Issue Jul 1, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@mrclay
Member

mrclay commented Jul 1, 2015

E.g. mod/profile/icondirect needs to load the dataroot without booting.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jul 1, 2015

Member

@ewinslow Why must Application::create be private?

Member

mrclay commented Jul 1, 2015

@ewinslow Why must Application::create be private?

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jul 1, 2015

feature(application): Allows fetching dataroot statically from Applic…
…ation

This moves the dataroot resolution from lib/configuration.php to the Application
and makes sure that create() sets/gets a singleton instance. Also updates
icondirect.php to use the new method.

Fixes #8653
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Jul 1, 2015

PR #8656

@ewinslow

This comment has been minimized.

Show comment
Hide comment
@ewinslow

ewinslow Jul 1, 2015

Member

It's not a must be private thing so much as a make everything private by default otherwise you'll have to support it forever thing.

Member

ewinslow commented Jul 1, 2015

It's not a must be private thing so much as a make everything private by default otherwise you'll have to support it forever thing.

@mrclay mrclay closed this in #8656 Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment