Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3031] breaks language overrides (Trac #883) #883

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 3 comments
Closed

[3031] breaks language overrides (Trac #883) #883

elgg-gitbot opened this issue Feb 16, 2013 · 3 comments

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/883 on 39202983-05-12 by cash, assigned to unknown.

Elgg version: 1.5

With array_merge, array elements of the second array override those of the first. With += they are ignored. This prevents plugins from overriding the language strings of the core or other plugins.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

trac user marcus wrote on 39213140-11-02

(In [svn:3165]) Closes #883: Using different operator logic so that plugins can replace existing translation entries.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

trac user danielwells wrote on 39548314-01-20

I think it was the original intention of the core team to allow overrides of both the core text and plugins. This 'fix' ended up breaking both. Core text overrides no longer work and plugin text overrides where reversed (plugin on top overrides plugins below it).

This makes me wonder if this was ever really broken at all. Changing my code back to use the original array_merge seems to make everything work fine. I am not sure what was broken to begin with.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 39548373-03-31

Daniel - the array_merge was functionally fine, but it was slow. The += was used in Elgg 1.5 to speed up the process with the unintended side effect of breaking overrides. It was then fixed in svn after the release of 1.5 but there are no releases out there with the fix. I think a 1.6 release is going to happen soon. You could wait for that release or test against a svn build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant