New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing raw translation strings should still show human-readable translations #8834

Closed
ewinslow opened this Issue Aug 11, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@ewinslow
Member

ewinslow commented Aug 11, 2015

Suppose we have:

return array(
  'menus:footer:items:home:label' => 'Home',
);

I think "show raw translation strings" should render like this:

Home (menus:footer:items:home:label)

Rather than the current

menus:footer:items:home:label

Which to me is very unreadable and encourages me to turn the setting off instead of just leaving it on.

ewinslow added a commit to ewinslow/Elgg that referenced this issue Aug 11, 2015

feature(developers): Always show human-readable translations
Even when the `show_strings` setting is turned on, it's nice to
be able to navigate the app. This makes it so that the translation
keys are just appended to the translated string, rather than replacing
them entirely.

Fixes #8834

ewinslow added a commit that referenced this issue Aug 11, 2015

feature(developers): Always show human-readable translations
Even when the `show_strings` setting is turned on, it's nice to
be able to navigate the app. This makes it so that the translation
keys are just appended to the translated string, rather than replacing
them entirely.

Before: `developers🏷show_strings`

After: `Show raw translation strings (developers🏷show_strings)`

Fixes #8834

ewinslow added a commit to ewinslow/Elgg that referenced this issue Aug 11, 2015

feature(developers): Always show human-readable translations
Even when the `show_strings` setting is turned on, it's nice to
be able to navigate the app. This makes it so that the translation
keys are just appended to the translated string, rather than replacing
them entirely.

Before: `developers🏷show_strings`

After: `Show raw translation strings (developers🏷show_strings)`

Fixes #8834

ewinslow added a commit to ewinslow/Elgg that referenced this issue Aug 11, 2015

feature(developers): Always show human-readable translations
Even when the `show_strings` setting is turned on, it's nice to
be able to navigate the app. This makes it so that the translation
keys are just appended to the translated string, rather than replacing
them entirely.

Before: `developers🏷show_strings`

After: `Show raw translation strings (developers🏷show_strings)`

Fixes #8834

ewinslow added a commit to ewinslow/Elgg that referenced this issue Aug 11, 2015

feature(developers): Always show human-readable translations
Even when the `show_strings` setting is turned on, it's nice to
be able to navigate the app. This makes it so that the translation
keys are just appended to the translated string, rather than replacing
them entirely.

Before: `developers🏷show_strings`

After: `Show raw translation strings (developers🏷show_strings)`

Fixes #8834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment