New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove width and height from .elgg-icon #8861

Closed
hypeJunction opened this Issue Aug 17, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@hypeJunction
Contributor

hypeJunction commented Aug 17, 2015

.fa selector set display to inline-block, which forces all icons to overflow their 16x16 container set in .elgg-icon, this causes issues when the font-size, line-height or vetical alignment changes.

juho-jaakkola added a commit to juho-jaakkola/Elgg that referenced this issue Aug 18, 2015

fix(icons): sizes of Font awesome icons are now more consistent with …
…old icons

 - Individually increases the size of some icons that were looking too small
 - Removes fixed width and height from icon containers
 - Increases default icon font size from 16px to 18px

Fixes #8733, #8861

juho-jaakkola added a commit to juho-jaakkola/Elgg that referenced this issue Aug 18, 2015

fix(icons): sizes of Font awesome icons are now more consistent with …
…old icons

 - Individually increases the size of some icons that were looking too small
 - Removes fixed width and height from icon containers
 - Increases default icon font size from 16px to 18px

Fixes #8733, #8861
@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Apr 12, 2016

Member

Fixed in #8855

Member

jdalsem commented Apr 12, 2016

Fixed in #8855

@jdalsem jdalsem closed this Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment