New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages Write Access: Missing Access Level Name #8905

Closed
susiefen opened this Issue Sep 3, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@susiefen

susiefen commented Sep 3, 2015

Newbie here, and just started working on Elgg and Git a few days ago. Although this looks like a simple fix, I don't want to change anything because I am still learning how this all works and don't want to break anything.

When creating a page, the write access has four levels; private, friends, logged in users and "missing access level name". I think this is supposed to be public.

screen shot 2015-09-03 at 9 00 27 am

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Sep 3, 2015

Member

Which Elgg version are you using?

Please disable all non-bundled plugins and verify whether the problem occurs when using just the default plugins.

Member

juho-jaakkola commented Sep 3, 2015

Which Elgg version are you using?

Please disable all non-bundled plugins and verify whether the problem occurs when using just the default plugins.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Sep 3, 2015

Contributor

I have seen this happen with walled garden enabled. Has been reported
somewhere
On Sep 3, 2015 4:17 PM, "Juho Jaakkola" notifications@github.com wrote:

Which Elgg version are you using?

Please disable all non-bundled plugins and verify whether the problem
occurs when using just the default plugins.


Reply to this email directly or view it on GitHub
#8905 (comment).

Contributor

hypeJunction commented Sep 3, 2015

I have seen this happen with walled garden enabled. Has been reported
somewhere
On Sep 3, 2015 4:17 PM, "Juho Jaakkola" notifications@github.com wrote:

Which Elgg version are you using?

Please disable all non-bundled plugins and verify whether the problem
occurs when using just the default plugins.


Reply to this email directly or view it on GitHub
#8905 (comment).

@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Sep 15, 2015

Member

Found the reason for this - site default access is set to public, but the pages plugin removes that as an option from the write access array
The input/access view then treats it as a custom acl an attempts to find the name, but since ACCESS_PUBLIC is not a real acl it can't find it and sticks in the placeholder text.

Pages plugin should modify the view vars and modify the value if ACCESS_PUBLIC is being passed due to site default access.

Member

beck24 commented Sep 15, 2015

Found the reason for this - site default access is set to public, but the pages plugin removes that as an option from the write access array
The input/access view then treats it as a custom acl an attempts to find the name, but since ACCESS_PUBLIC is not a real acl it can't find it and sticks in the placeholder text.

Pages plugin should modify the view vars and modify the value if ACCESS_PUBLIC is being passed due to site default access.

@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Sep 15, 2015

Member

Actually, if a core access level is not in the array should the input/access view display it anyway? This could be fixed at the core input/access view. Otherwise unwanted access levels will present any time it's passed as a default value.

Member

beck24 commented Sep 15, 2015

Actually, if a core access level is not in the array should the input/access view display it anyway? This could be fixed at the core input/access view. Otherwise unwanted access levels will present any time it's passed as a default value.

beck24 added a commit to beck24/Elgg that referenced this issue Sep 16, 2015

fix(pages): Prevent public "Missing access level" in write access field
This was previously being populated by default access on a non-edit form

Fixes #8905
@beck24

This comment has been minimized.

Show comment
Hide comment
@beck24

beck24 Sep 16, 2015

Member

I decided the input/access view should stay as-is and this should be the responsibility of the pages plugin to enforce its allowed values.

Member

beck24 commented Sep 16, 2015

I decided the input/access view should stay as-is and this should be the responsibility of the pages plugin to enforce its allowed values.

@beck24 beck24 closed this in 4174b77 Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment