New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow (some) user lookups to find hidden/disabled users #8941

Closed
mrclay opened this Issue Sep 16, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@mrclay
Member

mrclay commented Sep 16, 2015

When we added entity::canDelete() we allow it to look up hidden/disabled users. It's odd we do this for canDelete, but not canEdit or others (AFAICT).

cc @jdalsem

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Sep 16, 2015

Member

We moved that discussion to #8038 as you can read here #8031 (comment)

Member

jdalsem commented Sep 16, 2015

We moved that discussion to #8038 as you can read here #8031 (comment)

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Sep 16, 2015

PR #8944

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 16, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038
Fixes #8945

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 17, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

This also adds functionality to the internal entity getter allowing fetching
entities that may be hidden/disabled.

Fixes #8941
Fixes #8038
Fixes #8945

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Sep 20, 2015

fix(permissions): All permissions functions handle user fetches consi…
…stently

All permissions functions now find hidden/disabled users and, when a
given GUID isn't found, they return false and issue a warning. Previously,
only some functions issued warnings, and some functions would silently
substitute the logged in user if a given GUID couldn't load.

Fixes #8941
Fixes #8038
Fixes #8945

@mrclay mrclay closed this in #8944 Oct 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment