New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set rel="nofollow" for external links #9146

Closed
hypeJunction opened this Issue Nov 25, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@hypeJunction
Contributor

hypeJunction commented Nov 25, 2015

Any reason why we don't trust internal links by default? I propose we only default is_trusted flag to false if the link is outside an Elgg installation.

See #9117

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Nov 25, 2015

Member

SGTM

Member

mrclay commented Nov 25, 2015

SGTM

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Nov 26, 2015

Contributor

Can we treat this as a bug and fix in 1.12?

Contributor

hypeJunction commented Nov 26, 2015

Can we treat this as a bug and fix in 1.12?

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Nov 26, 2015

Member

IMO yes.

Member

mrclay commented Nov 26, 2015

IMO yes.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 8, 2015

Member

Fixed by #9208

Member

mrclay commented Dec 8, 2015

Fixed by #9208

@mrclay mrclay closed this Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment