Keep track of registered toggleable menu items #9151

Closed
hypeJunction opened this Issue Nov 26, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@hypeJunction
Contributor

hypeJunction commented Nov 26, 2015

We need to avoid duplicate registration of toggleable menu items. Event handlers are bound multiple times if called from multiple locations, so have to do this madness: https://github.com/hypeJunction/Elgg-actions_feature/blob/master/views/default/feature.js

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 8, 2015

Member

Event handlers are bound multiple times if called from multiple locations

Where does this happen?

Member

mrclay commented Dec 8, 2015

Event handlers are bound multiple times if called from multiple locations

Where does this happen?

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Dec 8, 2015

Contributor

It's a potential collision with all toggleable menu items. If I were to implement a plugin that needs to toggle between feature and feature, I would be duplicating the event binding, unless I shut down the groups plugin js.

Contributor

hypeJunction commented Dec 8, 2015

It's a potential collision with all toggleable menu items. If I were to implement a plugin that needs to toggle between feature and feature, I would be duplicating the event binding, unless I shut down the groups plugin js.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Dec 11, 2015

Member

related to #8158

Member

jdalsem commented Dec 11, 2015

related to #8158

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Dec 18, 2015

Contributor

Fixed by #9204

Contributor

hypeJunction commented Dec 18, 2015

Fixed by #9204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment