Client-side hook/type names can't contain `.` #9160

Closed
mrclay opened this Issue Nov 28, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@mrclay
Member

mrclay commented Nov 28, 2015

If the name has a period, an error is thrown. If the type has a period, the data matrix in elgg.config.hooks ends up containing misshapen data that I'm guessing is causing bugs we haven't found.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 6, 2015

fix(js): client-side hooks can now handle periods in hook names
Previously, using a hook name with a period would fail, and using a hook type
with a period would create an unexpected data structure within `elgg.config.hooks`.

This allows `elgg.provides()` to handle arbitrary names by giving them as an
array, and uses this new API to handle hook names/types consistently.

Fixes #9160
@mrclay

This comment has been minimized.

Show comment
Hide comment
Member

mrclay commented Dec 6, 2015

PR #9201

@mrclay mrclay closed this in #9201 Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment