Flood of "mkdir(): File exists" warnings on SimpleCache reset #9219

Closed
iionly opened this Issue Dec 12, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@iionly
Contributor

iionly commented Dec 12, 2015

Warnings refer to invalidate() function: https://github.com/Elgg/Elgg/blob/2.0/engine/classes/Elgg/Cache/SimpleCache.php#L177.

I see a mkdir() in this line followed by a _elgg_rmdir() in the next line. Could it be that it should be the other way round, i.e. first removal and then re-creation?

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Dec 22, 2015

Member

The call to _elgg_rmdir() does not remove the directory itself, but just its contents. So I believe the call to mkdir() can be removed completely.

Member

juho-jaakkola commented Dec 22, 2015

The call to _elgg_rmdir() does not remove the directory itself, but just its contents. So I believe the call to mkdir() can be removed completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment