New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 undocumented migrate action when extending js/admin #9238

Closed
jdalsem opened this Issue Dec 16, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@jdalsem
Member

jdalsem commented Dec 16, 2015

It is still possible to extend js/elgg, but this does not apply to js/admin anymore. Was this intended? If so, we need it documented somewhere. This is probably intended to get plugin devs to use AMD, but extending js/admin is very common, so explicit documentation about this change is appreciated.

@jdalsem jdalsem added the docs label Dec 16, 2015

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 17, 2015

Member

I think this late we should just allow extending js/admin to work. I.e. make an empty view and include it on every admin page. Somehow deprecate it.

Member

mrclay commented Dec 17, 2015

I think this late we should just allow extending js/admin to work. I.e. make an empty view and include it on every admin page. Somehow deprecate it.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 17, 2015

Member

It's in the Changelog but not the upgrading plugins guide.

Member

mrclay commented Dec 17, 2015

It's in the Changelog but not the upgrading plugins guide.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 17, 2015

fix(admin): Allow plugins to extend js/admin but deprecate it
The view js/admin was replaced in 2.0 but this was never mentioned in the
plugin upgrade guide. We bring it back here for BC but formally deprecate
it if any plugin extends it.

Fixes #9238
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 17, 2015

Member

See #9241.

Member

mrclay commented Dec 17, 2015

See #9241.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 18, 2015

fix(admin): Allow plugins to extend js/admin but deprecate it
The view js/admin was replaced in 2.0 but this was never mentioned in the
plugin upgrade guide. We're supporting it for better BC.

Fixes #9238

@mrclay mrclay closed this in a5c2abd Dec 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment