New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fails in non-page requests #9244

Closed
mrclay opened this Issue Dec 18, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@mrclay
Member

mrclay commented Dec 18, 2015

Really two different bugs:

  1. When log to screen is off, warnings during cache requests end up with $display == true in Elgg\Logger::process. I.e. it echoes them, but thankfully it seems that output buffer is discarded so it doesn't break anything.
  2. When log to screen in on, messages are dumped into the ElggLogCache for screen output, but that output never occurs. The messages never escape the cache.
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Dec 18, 2015

Member

I'd prefer to get this fixed in 1.12 so devs can get access to any deprecation messages they've been missing.

Member

mrclay commented Dec 18, 2015

I'd prefer to get this fixed in 1.12 so devs can get access to any deprecation messages they've been missing.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 18, 2015

fix(logging): Log messages no longer discarded
Logged messages are no longer thrown away during action and cache requests.
Also the log-to-screen feature of the developers plugin no longer throws
away messages after the page display has occurred.

In both cases, these errors likely end up in the system error log.

Fixes #9244

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 18, 2015

chore(views): removes core use of elgg_get_view_location()
With #9244 fixed, these deprecation warning are no longer thrown away, so
we instead use the private API version to avoid them.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 18, 2015

chore(views): removes core use of elgg_get_view_location()
With #9244 fixed, these deprecation warning are no longer thrown away, so
we instead use the private API version to avoid them.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 21, 2015

chore(views): removes core use of elgg_get_view_location()
With #9244 fixed, these deprecation warning are no longer thrown away, so
we instead use the private API version to avoid them.

@mrclay mrclay closed this in 5020c52 Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment