Custom favicon is not working if system cache is enabled #9308

Closed
juho-jaakkola opened this Issue Jan 19, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@juho-jaakkola
Member

juho-jaakkola commented Jan 19, 2016

Custom favicon dropped to views/default/ works only if system cache is disabled.

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Jan 19, 2016

Member

It seems that this is always used and it cannot be overridden by plugins: https://github.com/Elgg/Elgg/blob/2.0/engine/views.php#L29

Member

juho-jaakkola commented Jan 19, 2016

It seems that this is always used and it cannot be overridden by plugins: https://github.com/Elgg/Elgg/blob/2.0/engine/views.php#L29

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Jan 19, 2016

Member

Shouldn't this be run only if system cache is not yet loaded: https://github.com/Elgg/Elgg/blob/2.0/engine/lib/views.php#L1583-L1589?

Currently it gets run on every page load regardless if system cache is on or off. Therefore it overrides the path declarations that are already in the cache.

Member

juho-jaakkola commented Jan 19, 2016

Shouldn't this be run only if system cache is not yet loaded: https://github.com/Elgg/Elgg/blob/2.0/engine/lib/views.php#L1583-L1589?

Currently it gets run on every page load regardless if system cache is on or off. Therefore it overrides the path declarations that are already in the cache.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jan 19, 2016

Member

Yep, seems like a big bug.

Member

mrclay commented Jan 19, 2016

Yep, seems like a big bug.

@mrclay mrclay added the critical label Jan 19, 2016

@mrclay mrclay added this to the Elgg 2.0.x milestone Jan 19, 2016

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 19, 2016

fix(views): locations specified in /engine/views.php are modifiable
When simplecache is on, all view locations are loaded from cache, so no
dir scanning/configuration should be done. In elgg_views_boot, we'd
forgotten to scan engine/views.php based on this condition. This moves
the scanning to the top and into the system cache conditional block.

This also gets rid of duplicated code that causes a double scan of the
core view files.

Fixes #9308
@mrclay

This comment has been minimized.

Show comment
Hide comment
Member

mrclay commented Jan 19, 2016

PR #9310

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Jan 25, 2016

Member

Fixed by #9310

Member

mrclay commented Jan 25, 2016

Fixed by #9310

@mrclay mrclay closed this Jan 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment