Fatal Error in installer #9334

Closed
hypeJunction opened this Issue Feb 1, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@hypeJunction
Contributor

hypeJunction commented Feb 1, 2016

Fatal error: Call to undefined method Elgg\Filesystem\File::putContents() in \engine\classes\ElggRewriteTester.php on line 192

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 1, 2016

Member

This call was added in f2118ef but putContents() was never added.

Member

mrclay commented Feb 1, 2016

This call was added in f2118ef but putContents() was never added.

@juho-jaakkola

This comment has been minimized.

Show comment
Hide comment
@juho-jaakkola

juho-jaakkola Feb 1, 2016

Member

How is it possible we haven't noticed this before? It's a fatal error after all.

Member

juho-jaakkola commented Feb 1, 2016

How is it possible we haven't noticed this before? It's a fatal error after all.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 1, 2016

Member

Oh, some of this was reverted. That file object usage never got into a 1.x release and appeared in 2.0.

Member

mrclay commented Feb 1, 2016

Oh, some of this was reverted. That file object usage never got into a 1.x release and appeared in 2.0.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 1, 2016

fix(installer): don't fatal trying to rewrite the .htaccess file
We forgot to add `Elgg\Filesystem\File::putContents` when the these file
system objects were added.

Fixes #9334
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 1, 2016

Member

PR #9336. @hypeJunction can you try this?

Member

mrclay commented Feb 1, 2016

PR #9336. @hypeJunction can you try this?

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Feb 1, 2016

Contributor

It was a new apache installation and I had to change some conf files for
rewrite rules to work. I will check the PR

On Monday, February 1, 2016, Steve Clay notifications@github.com wrote:

PR #9336 #9336. @hypeJunction
https://github.com/hypeJunction can you try this?


Reply to this email directly or view it on GitHub
#9334 (comment).

Contributor

hypeJunction commented Feb 1, 2016

It was a new apache installation and I had to change some conf files for
rewrite rules to work. I will check the PR

On Monday, February 1, 2016, Steve Clay notifications@github.com wrote:

PR #9336 #9336. @hypeJunction
https://github.com/hypeJunction can you try this?


Reply to this email directly or view it on GitHub
#9334 (comment).

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 5, 2016

Member

Closed by #9336

Member

mrclay commented Feb 5, 2016

Closed by #9336

@mrclay mrclay closed this Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment