popup menu and register page have wrong charset #9345

Closed
justangel opened this Issue Feb 5, 2016 · 14 comments

Comments

Projects
None yet
3 participants
@justangel

popup menu charset bug
2016-02-05 15-38-37

register page charset bug
2016-02-05 15-43-09
only Cancel button is ok, all other have wrong charset

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 5, 2016

i use elgg 1.12.8 version

i use elgg 1.12.8 version

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 5, 2016

Member

I could not duplicate this. What browser did you use?

Member

mrclay commented Feb 5, 2016

I could not duplicate this. What browser did you use?

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 5, 2016

hi, i tested on brousers: Google Chrome, Opera, Mozilla Firefox, Maxthon and Iron
this bug issued in 90% of cases, step by step:
0 - site is closed for unregistered (need to register/login)
1 - open site http://shareboor.net
2 - click on forgot password (and bug is occured)
3 - click cancel
4 - click register (bug is occured)
5 - click cancel
this is for login screen

hi, i tested on brousers: Google Chrome, Opera, Mozilla Firefox, Maxthon and Iron
this bug issued in 90% of cases, step by step:
0 - site is closed for unregistered (need to register/login)
1 - open site http://shareboor.net
2 - click on forgot password (and bug is occured)
3 - click cancel
4 - click register (bug is occured)
5 - click cancel
this is for login screen

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 5, 2016

Member

The ajax responses are being sent with ;charset=iso-8859-1 in the Content-Type (should be UTF-8). It looks like we don't explicitly send charset in ajax responses (definitely a bug). I wonder why no one else has had this problem...

When pages are sent directly, they're properly marked as UTF-8: http://shareboor.net/register, http://shareboor.net/forgotpassword

Member

mrclay commented Feb 5, 2016

The ajax responses are being sent with ;charset=iso-8859-1 in the Content-Type (should be UTF-8). It looks like we don't explicitly send charset in ajax responses (definitely a bug). I wonder why no one else has had this problem...

When pages are sent directly, they're properly marked as UTF-8: http://shareboor.net/register, http://shareboor.net/forgotpassword

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 5, 2016

Member

You can try adding this to .htaccess: AddDefaultCharset utf-8

Member

mrclay commented Feb 5, 2016

You can try adding this to .htaccess: AddDefaultCharset utf-8

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Feb 5, 2016

Contributor

Another use case for using Symfony Response more widely.

Contributor

hypeJunction commented Feb 5, 2016

Another use case for using Symfony Response more widely.

@mrclay

This comment has been minimized.

Show comment
Hide comment
Member

mrclay commented Feb 5, 2016

PR #9349

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 5, 2016

thx, this solved the problem with popups menus, but with register/recovery password pages not

thx, this solved the problem with popups menus, but with register/recovery password pages not

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 8, 2016

Member

Let me look more into this...

Member

mrclay commented Feb 8, 2016

Let me look more into this...

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 8, 2016

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 8, 2016

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 8, 2016

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 8, 2016

Member

@justangel Try #9349 again. I've updated it to set charset in more cases.

Member

mrclay commented Feb 8, 2016

@justangel Try #9349 again. I've updated it to set charset in more cases.

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 8, 2016

thank you very much @mrclay

when edited "Router.php" file, immediately stopped delete "/register" in the address bar
I logged on the site
chose a different default language
then I went to check the registration
again removed "/register" in the address bar
"Cancel" button is present
and everything is displayed in the correct encoding

thank you very much for the quick help in our problem

thank you very much @mrclay

when edited "Router.php" file, immediately stopped delete "/register" in the address bar
I logged on the site
chose a different default language
then I went to check the registration
again removed "/register" in the address bar
"Cancel" button is present
and everything is displayed in the correct encoding

thank you very much for the quick help in our problem

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Feb 8, 2016

Member

To be clear, are you saying #9349 solves all the problems?

Member

mrclay commented Feb 8, 2016

To be clear, are you saying #9349 solves all the problems?

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 8, 2016

@mrclay yes, all is ok for now

@mrclay yes, all is ok for now

@justangel

This comment has been minimized.

Show comment
Hide comment
@justangel

justangel Feb 8, 2016

present "Cancel" btn or not, not critical, everything is fine, it is important

present "Cancel" btn or not, not critical, everything is fine, it is important

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 9, 2016

@mrclay mrclay closed this in 3dab7d1 Feb 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment