Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
"Infinite loop attempting to show error page" for non existing group profile page #9476
when attempting to view
reason is https://github.com/Elgg/Elgg/blob/2.0/mod/groups/start.php#L162 which triggers (for the 2nd time) the error page handler
In 1.12, 404 forwards were allowed to nest, going through elgg_error_page_handler() multiple times, basically the last one "winning" to draw the page.
This was dangerous, but I didn't run into an infinite loop until doing the views overhaul in 2.0. At which point I (wrongly) assumed even twice was a sign of an infinite loop and I added the abrupt exit.
After #9440, the pagesetup is no longer triggered by the resource/group/profile page, so the page resource does the first 404, the error page triggers pagesetup, and the pagesetup handler for group triggers the 2nd 404.
A simple fix would be to allow maybe 3 calls to elgg_error_page_handler() before pulling the plug.
We can add proper page handlers for error codes and actually redirect to