New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer is broken #9486

Closed
hypeJunction opened this Issue Mar 15, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@hypeJunction
Contributor

hypeJunction commented Mar 15, 2016

I am unable to install Elgg 2.1 or Elgg 2.x. I narrowed it down to _elgg_services()->simpleCache call, so something is happening in DI factory that's causing an infinite loop...

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 15, 2016

Contributor

The offender is Elgg\Config:loadSettingsFile, which is called by the db factory, called by the simpleCache factory. It sets the location header to install.php thus causing an infinite loop.

Contributor

hypeJunction commented Mar 15, 2016

The offender is Elgg\Config:loadSettingsFile, which is called by the db factory, called by the simpleCache factory. It sets the location header to install.php thus causing an infinite loop.

@hypeJunction hypeJunction changed the title from simpleCache is choking the installer to Installer is broken Mar 15, 2016

@mrclay mrclay added this to the Elgg 2.1.x milestone Mar 15, 2016

@vPriVate

This comment has been minimized.

Show comment
Hide comment
@vPriVate

vPriVate Mar 17, 2016

Same here :(

vPriVate commented Mar 17, 2016

Same here :(

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 17, 2016

Member

Working on this

Member

mrclay commented Mar 17, 2016

Working on this

@mrclay mrclay self-assigned this Mar 17, 2016

@mrclay mrclay added the critical label Mar 17, 2016

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Mar 17, 2016

fix(installer): no longer redirects in loop during installation
`Elgg\Config::loadSettingsFile` now recognizes when it's in the installer
and no longer redirects if no settings file is found.

Fixes #9486
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Mar 17, 2016

PR #9509

@jdalsem jdalsem closed this Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment