developer tools no longer shows all hooks/events callbacks #9527

Closed
jeabakker opened this Issue Mar 21, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@jeabakker
Member

jeabakker commented Mar 21, 2016

in the inspect listing of hooks/events not all registered functions are listed

probably has todo with 3e6a289

@jeabakker jeabakker changed the title from developer tools no longer shows correct hooks/events to developer tools no longer shows all hooks/events callbacks Mar 21, 2016

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 22, 2016

Member

Can you give me a specific hook and event missing?

Member

mrclay commented Mar 22, 2016

Can you give me a specific hook and event missing?

@jeabakker

This comment has been minimized.

Show comment
Hide comment
@jeabakker

jeabakker Mar 22, 2016

Member

for example i want to inspect all register menu:entity

currently (elgg 2.1.1) i get this list ;)
dev_tools hooks

I'm missing just a few registered functions

Member

jeabakker commented Mar 22, 2016

for example i want to inspect all register menu:entity

currently (elgg 2.1.1) i get this list ;)
dev_tools hooks

I'm missing just a few registered functions

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 22, 2016

Contributor

Something is off in your setup, IMO.
inspector

Contributor

hypeJunction commented Mar 22, 2016

Something is off in your setup, IMO.
inspector

@jeabakker

This comment has been minimized.

Show comment
Hide comment
@jeabakker

jeabakker Mar 22, 2016

Member

i did a fresh git pull just before the screenshot was made :(

Member

jeabakker commented Mar 22, 2016

i did a fresh git pull just before the screenshot was made :(

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Mar 22, 2016

Contributor

Same list in 2.1

Contributor

hypeJunction commented Mar 22, 2016

Same list in 2.1

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 23, 2016

Member

And you're sure those calls are being made in the register hook?

Member

mrclay commented Mar 23, 2016

And you're sure those calls are being made in the register hook?

@jeabakker

This comment has been minimized.

Show comment
Hide comment
@jeabakker

jeabakker Mar 23, 2016

Member

search through core for menu:entity and you should get something like the list @hypeJunction showed, but for me i get a much shorter list :( I don't get why

Member

jeabakker commented Mar 23, 2016

search through core for menu:entity and you should get something like the list @hypeJunction showed, but for me i get a much shorter list :( I don't get why

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 23, 2016

Member

I also just see likes_entity_menu_setup. 😕 Works in 1.12. May be a regression since 2.0.

Member

mrclay commented Mar 23, 2016

I also just see likes_entity_menu_setup. 😕 Works in 1.12. May be a regression since 2.0.

@mrclay

This comment has been minimized.

Show comment
Hide comment
Member

mrclay commented Mar 24, 2016

PR #9566

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Mar 24, 2016

Member

In 2.0 for a (hook, type) pair, each unique priority is stored in a separate array of handlers. Only the last priority in the list was making it through. @hypeJunction had likes disabled, so the 400 priority didn't wipe out the others. This also fixes the priority ordering.

Member

mrclay commented Mar 24, 2016

In 2.0 for a (hook, type) pair, each unique priority is stored in a separate array of handlers. Only the last priority in the list was making it through. @hypeJunction had likes disabled, so the 400 priority didn't wipe out the others. This also fixes the priority ordering.

@jdalsem jdalsem closed this Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment