Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Should icon service always save 'original' image size? #9970
The EntityIconService has a minor problem. Every time an icon is cropped, the cropping affects all image sizes including the largest 'master' size. This causes the image quality of the master icon to deteriorate every time the icon is cropped.
Perhaps we should always save also the original image with the "size"
referenced this issue
Jul 11, 2016
One option is to calculate if cropping coordinates are a square and decide
Perhaps we could allow passing in an image size config that would skip the
Reply to this email directly, view it on GitHub
That won't help with custom image types. They could have any aspect ratio.
How about skipping crop/resize if the configuration value is e.g. an empty array:
array( 'medium' => array('w' => 100, 'h' => 100, 'square' => true, 'upscale' => true), 'large' => array('w' => 200, 'h' => 200, 'square' => false, 'upscale' => false), 'original' => array() );
What are the main use cases for creating an image with
I would guess in most cases it is appropriate to make a duplicate. At least I personally would like to have a copy in case the original source image gets removed.