Updated the unregister_entity_type() type function #185

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@teamwebgalli
Contributor

Added the "elgg_" prefix to unregister_entity_type()
Moved unregister_entity_type() to deprecated 1.8

@ewinslow
Member
ewinslow commented Apr 9, 2012

Hey,

If we deprecate this function it would be in 1.9, so you should move it to deprecated-1.9.php.

Also, the elgg-prefixed version needs an @since 1.9 annotation to make it easy to see when it was introduced.

@teamwebgalli
Contributor

Thanks for the info evan. Will move it to 1.9

@ewinslow
Member

Hey, just checking in here. Think you'll be able to get to this?

Also, is it possible to remove the twitter typo fix from this patch?

@cash
Contributor
cash commented Jun 20, 2012

Pulled in for 1.9 (to master): [efbe821]

@cash cash closed this Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment