Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Updated the unregister_entity_type() type function #185

Closed
wants to merge 3 commits into from

3 participants

@teamwebgalli

Added the "elgg_" prefix to unregister_entity_type()
Moved unregister_entity_type() to deprecated 1.8

@ewinslow
Owner

Hey,

If we deprecate this function it would be in 1.9, so you should move it to deprecated-1.9.php.

Also, the elgg-prefixed version needs an @since 1.9 annotation to make it easy to see when it was introduced.

@teamwebgalli

Thanks for the info evan. Will move it to 1.9

@ewinslow
Owner

Hey, just checking in here. Think you'll be able to get to this?

Also, is it possible to remove the twitter typo fix from this patch?

@cash
Owner

Pulled in for 1.9 (to master): [efbe821]

@cash cash closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
12 engine/lib/deprecated-1.8.php
@@ -4772,3 +4772,15 @@ function default_page_handler($page, $handler) {
return FALSE;
}
+
+/**
+ * Unregisters an entity type and subtype as a public-facing entity.
+ *
+ * @deprecated 1.8 Use elgg_unregister_entity_type()
+ */
+function unregister_entity_type($type, $subtype) {
+
+ elgg_deprecated_notice("unregister_entity_type() functions were deprecated in 1.8. Use elgg_unregister_entity_type() instead.", 1.8);
+
+ return elgg_unregister_entity_type($type, $subtype);
+}
View
2  engine/lib/entities.php
@@ -2002,7 +2002,7 @@ function elgg_register_entity_type($type, $subtype = null) {
* @return true|false Depending on success
* @see elgg_register_entity_type()
*/
-function unregister_entity_type($type, $subtype) {
+function elgg_unregister_entity_type($type, $subtype) {
global $CONFIG;
$type = strtolower($type);
View
2  mod/twitter_api/lib/twitter_api.php
@@ -109,7 +109,7 @@ function twitter_api_login() {
$user = twitter_api_create_user($twitter);
$site_name = elgg_get_site_entity()->name;
system_message(elgg_echo('twitter_api:login:email', array($site_name)));
- $forward = "twitter_api/intersitial";
+ $forward = "twitter_api/interstitial";
}
// set twitter services tokens
Something went wrong with that request. Please try again.