Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to ElggInspector class for array format of callback functions #186

Merged
merged 0 commits into from May 7, 2012

Conversation

Srokap
Copy link
Contributor

@Srokap Srokap commented Apr 11, 2012

No description provided.

@@ -40,6 +40,7 @@ function developers_process_settings() {
$cache = new ElggLogCache();
elgg_set_config('log_cache', $cache);
elgg_register_plugin_hook_handler('debug', 'log', array($cache, 'insertDump'));
elgg_unextend_view('page/elements/foot', 'developers/log');//fix duplicate extension - caused by view cacheing problem due to too early call of extend view
Copy link
Contributor

@ewinslow ewinslow Apr 17, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we figure out a better way to fix this problem? Also, is there a ticket for this?

Copy link
Contributor Author

@Srokap Srokap Apr 23, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following commit does the trick in better way. In general it makes problems if we extend views while first processing the start.php file, as the extensions will be saved to filepath cache and re-extended on second display after filepath cache refresh.

According to ticket, I didn't create one, as it was only annoying to me and obviously trivial fix. Should I create tickets for each change?

@Srokap Srokap merged commit 0fccc58 into Elgg:master May 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants