Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microformats #343

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
4 participants
@benwerd
Copy link
Contributor

commented Jul 25, 2012

Added some microformat fields to the profile.

tantek and others added some commits Jul 25, 2012

Update header docs, add microformats u-url url
Update header docs re: rel and class attributes, add microformats u-url and url classes for general use inside hCard (h-card), and potentially others like hCalendar (h-event) as well. Paired with @benwerd.
Added URL and location classes in profile
Specifically, added h-card and p-location fields.
} else {
$vars['class'] = '';
}
$vars['class'] .= 'u-url url';

This comment has been minimized.

Copy link
@ewinslow

ewinslow Jul 28, 2012

Member

Hey, @benwerd, thanks for the PR!

Do you think it make sense to do this for all urls? We use this view everywhere such as in menu items and such, where it is not associated with a particular entity's profile information.

This comment has been minimized.

Copy link
@benwerd

benwerd Jul 30, 2012

Author Contributor

It's definitely not limited to profile info (there are further microformats for that) - but it does make sense to limit it to external URLs, you're right.

$outputvars = array('value' => $user->$shortname);
// Add microformats where possible
switch($valtype) {

This comment has been minimized.

Copy link
@lowfill

lowfill Jul 30, 2012

Contributor

What about make this part a hook? I guess some extra microformats could be added in the future.

This comment has been minimized.

Copy link
@benwerd

benwerd Jul 30, 2012

Author Contributor

That makes a lot of sense to me. Trick is, you need hooks for context, and also general hooks for different types (eg links have some base microformat classes).

@ewinslow

This comment has been minimized.

Copy link
Member

commented Mar 31, 2013

Terribly sorry to do this, but I think we need to close this PR:

  1. This can no longer be merged cleanly
  2. It doesn't seem like anyone is itching to get this in
  3. The value proposition isn't immediately clear to me.
  4. There's no way to test for regressions, and none of the current devs are familiar with the format, so maintenance is doomed...
    .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.