feature(routing): allow more reliable URL path rewriting #9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My goal was to minimize the API surface area we have to support, and make conversion to the new hook easy. |
|
While this only covers the the path, you can still use get/set_input for GET vars, but ?hl and ?view have already been read by the time this hook executes. |
Adds an early called `route:rewrite` hook expressly for URL rewriting. Changes there update the request object and affect the default context, and functions like current_page_url(). Removes legacy magic quotes-related code. Fixes Elgg#9388
|
👍 LGTM |
|
LGTM |
mrclay
added a commit
that referenced
this pull request
Feb 16, 2016
feature(routing): allow more reliable URL path rewriting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an early called
route:rewritehook expressly for URL rewriting. Changes there update the request object and affect the default context, and functions like current_page_url().Removes legacy magic quotes-related code.
Fixes #9388