Skip to content

Conversation

@Eliav2
Copy link
Owner

@Eliav2 Eliav2 commented Nov 15, 2025

Note

Simplifies OverflowList visibility handling by removing React.Activity and pins workspace React packages to ~19.2.0.

  • Components:
    • src/components/OverflowList.tsx:
      • Simplifies default renderItemVisibility: removes React.Activity usage and returns null for non-visible items, Fragment for visible ones.
  • Config:
    • pnpm-workspace.yaml: Pins catalog entries for react, react-dom, @types/react, @types/react-dom from caret to tilde (~19.2.0).

Written by Cursor Bugbot for commit 48204c9. This will update automatically on new commits. Configure here.

@codesandbox
Copy link

codesandbox bot commented Nov 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Nov 15, 2025

Deploy Preview for react-responsive-overflow-list ready!

Name Link
🔨 Latest commit 5510965
🔍 Latest deploy log https://app.netlify.com/projects/react-responsive-overflow-list/deploys/692d72efbc4ba7166fe7607d
😎 Deploy Preview https://deploy-preview-10--react-responsive-overflow-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 24

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: React Activity Removal Undermines React 19+ Benefits

The removal of React.Activity component usage breaks the intended React 19.2+ feature. The code previously wrapped hidden items with Activity to keep them mounted while toggling visibility, but now always unmounts them by returning null. This contradicts the documented behavior and defeats the benefit of upgrading to React 19.2+, where hidden items should remain mounted via Activity to avoid state loss and flickering when children change sizes.

src/components/OverflowList.tsx#L229-L235

const finalRenderItemVisibility =
renderItemVisibility ??
((node, meta) => {
if (!meta.visible) return null;
return <React.Fragment key={meta.index}>{node}</React.Fragment>;
});

Fix in Cursor Fix in Web


@Eliav2
Copy link
Owner Author

Eliav2 commented Nov 16, 2025

closing as its just for demo for possible react bug

@Eliav2 Eliav2 closed this Nov 16, 2025
@Eliav2 Eliav2 reopened this Dec 1, 2025
@Eliav2 Eliav2 closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants