Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird things in Nautilus #8

Closed
ginwsby opened this issue Nov 19, 2018 · 13 comments · Fixed by #35

Comments

@ginwsby
Copy link

commented Nov 19, 2018

Hi, I use Nordic in Gnome 3.30. I don't know how to explain this bug, but sometimes, when Nautilus is unfocused happen this:
schermata da 2018-11-19 20-55-24

@EliverLara

This comment has been minimized.

Copy link
Owner

commented Nov 24, 2018

Hi, I've never faced that issue, I'll try to reproduce that.

@badunit

This comment has been minimized.

Copy link

commented Feb 2, 2019

And here we go... like Sweet Theme, also this theme is affected with Nautilus lost-focus bug...

This bug occur, when Nautilus window lost focus, for example opening the terminal in foreground...


 ██████████████████  ████████     badunit@CORE
 ██████████████████  ████████     OS: Manjaro 18.0.2 Illyria
 ██████████████████  ████████     Kernel: x86_64 Linux 4.20.3-1-MANJARO
 ██████████████████  ████████     Uptime: 1d 2h 44m
 ████████            ████████     Packages: 1384
 ████████  ████████  ████████     Shell: bash 5.0.0
 ████████  ████████  ████████     Resolution: 4160x1440
 ████████  ████████  ████████     DE: GNOME 
 ████████  ████████  ████████     WM: GNOME Shell
 ████████  ████████  ████████     WM Theme: Nordic-bluish-accent
 ████████  ████████  ████████     GTK Theme: Nordic-bluish-accent [GTK2/3]
 ████████  ████████  ████████     Icon Theme: Newaita-dark
 ████████  ████████  ████████     Font: Noto Sans 11
 ████████  ████████  ████████     CPU: Intel Core i7-6700K @ 8x 4.2GHz [36.0°C]
                                  GPU: GeForce GTX 1080, GeForce GTX 1080
                                  RAM: 17758MiB / 32129MiB

Here is my screen:
issue
don't mind pixelated part... privacy eheh

I dont' want to be rude, but if this bug happen in Sweet theme too.. i think there is something wrong in coding of these themes...

Anyway your themes are really good and Nordic at the moment is the nicest theme i've seen on my Gnome!

@atomically

This comment has been minimized.

Copy link

commented Jun 15, 2019

It was requested after I posted on opendesktop to post here. This is the exact same issue I have as well, so I did not open a new issue.

System is: Arch Linux, Kernel 5.1.9-arch1-1-ARCH, Gnome 3.32.2, Nvidia 980 Ti.

Screenshot from 2019-06-15 11-22-17

@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I am also seeing this issue. Any suggestions on where to look in the code to provide a fix?

@EliverLara

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2019

Hi, @kgilmer the issue should be on the gtk-3.0/widgets/_sidebar.scss file. I think maybe adding a background-color: transparent; in the highlighted block of the image could fix it:

Captura de pantalla de 2019-09-01 12-37-01

if you could try it it would be helpful

@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Thanks for the tip @EliverLara ...hmm, I changed that but didn't notice any change. I copied and changed theme and put it in another theme directory /usr/share/themes/Nordic2 and used gsettings to switch to the new theme. I used this to ensure I was loading my copied theme. Looking at it more closely, it appears that there is an animation that may be causing the issue. When the Files window is first defocused, the issue does not appear, and some elements change to show that the window is not in focus. Then, an animation runs that causes more fading, and the end result of this animation results in the issue. This is my first look into gtk themes but if there is a place that describes this animation, I'm guessing this may be where the issue is.

Edit:

$ diff -r Nordic Nordic2
diff -r Nordic/gtk-3.0/widgets/_sidebar.scss Nordic2/gtk-3.0/widgets/_sidebar.scss
138c138,139
<                                               color: #98abb2;
---
>             color: #98abb2;
>             background-color: transparent;
@EliverLara

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2019

@kgilmer did you recompile the theme to generate the new gtk.css file?

@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Another clue that it's due to the animation and not the static settings is that the problem doesn't occur if I don't cause the Files window to lose focus on a screen.

This causes the problem.

  1. Open Files window
  2. Open terminal
  3. Set Files to have focus
  4. Set Terminal to have focus

Result: Notice Files has dirty background in selected sidebar icon after lose-focus animation.

This results in the same end state (Files no focus, Terminal focus), but does not exhibit the issue:

  1. Open Files window
  2. Open terminal
  3. Set Files to have focus
  4. Set Terminal to have focus
  5. Navigate to different workspace
  6. Return to workspace.

Result: Notice Files is not in focus but does not have dirty background in sidebar icon.

Image:
image

@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

@kgilmer did you recompile the theme to generate the new gtk.css file?

Er, no I wasn't aware of that. Any suggestions on the quickest way to learn?

@EliverLara

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2019

To recompile just do the following:

  • cd gtk-3.0
  • sass gtk.scss gtk.css
@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Thanks @EliverLara . I tried that with your original suggestion and did not see any change from original behavior. Following up on my theory that it's due to the animation (called a transition it seems), I disabled all transition in the sidebar. I do not see the problem now, so this seems to be other point in favor of an issue w/ the transition itself.

31c31
<     transition: $backdrop_transition;
---
>     // transition: $backdrop_transition;
36c36
<     transition: all .12s ease-in;
---
>     // transition: all .12s ease-in;
64c64
<         transition: all .12s ease-in;
---
>         // transition: all .12s ease-in;
138c138,139
< 						color: #98abb2;
---
>             color: #98abb2;
>             background-color: transparent;
142c143
< 					transition: all 300ms cubic-bezier(0.25, 0.46, 0.45, 0.94);
---
> 					// transition: all 300ms cubic-bezier(0.25, 0.46, 0.45, 0.94);
@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I have root-caused the behavior to one line:

31c31
<     transition: $backdrop_transition;
---
>     // transition: $backdrop_transition;

image

@kgilmer

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I will create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.