Skip to content
This repository

minify output javascript problem #2092

Closed
hakimihamdan88 opened this Issue · 6 comments

4 participants

hakimihamdan88 Andrew Podner vkeranov Andrey Andreev
hakimihamdan88

i have problem with my google analytics (javascript error) when updating new update develop version

Andrew Podner

Can you provide some more details about where the problem is, and what JS code is involved.

vkeranov

varjs is not defined... Using the twitter api:

!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");

well, thanks for this hard work and commits, but if you're not testing javascript with twitter api or google analytics, then how you're testing it at all?

Andrew Podner

As mentioned by @narfbg in #2078 , "Minify output isn't perfect - it's experimental." If you want to provide a PR to improve it, or even the js code prior to minification, or a link to it, that would be most helpful. Thanks!

vkeranov

This js code is "as is", taken from the twitter developer's site... Almost every website, which has a "tweet this" button, uses this code. If you're using Google Analytics the code is provided in the same way... Sorry, but I can not give you another code. This is the link:
https://dev.twitter.com/docs/tweet-button

Andrew Podner

Exactly what I needed, thanks. Fix will be forthcoming.

Andrew Podner AndrewPodner referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Andrew Podner AndrewPodner referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Andrew Podner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 79b7027
Andrew Podner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 464a7b7
Andrew Podner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 58594ed
Andrew Podner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : code refinements 96b9501
Andrew Podner

@vkeranov @hakimihamdan88 I believe we have the reported issues solved. Please post back if you continue to have an issue. Thanks for reporting the issue

Kyra Zimmer nonchip referenced this issue from a commit in nonchip/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 2a1c6ba
Kyra Zimmer nonchip referenced this issue from a commit in nonchip/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 56ba5ac
Kyra Zimmer nonchip referenced this issue from a commit in nonchip/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method c0b7041
Kyra Zimmer nonchip referenced this issue from a commit in nonchip/CodeIgniter
Andrew Podner AndrewPodner issue #2092 : code refinements 679bcdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.