Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Many corrections made between June 24th and September 2nd #4

Merged
merged 45 commits into from Sep 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

ebeauchamps commented Sep 2, 2012

I made many corrections over a lengthy time span, trying to learn how to work correctly with Github. I don't own a license of expressionengine 2.5.2 but:

  • I have quite a bit of experience translating programs (I did the French translation for an orienteering software called PurplePen in LaunchPad)
  • I translated for my own needs EE core 1.6.8, working directly on the "lang" files.

I can understand very well if you want to take some care before introducing my changes to ee (because you don't know me). Perhaps you could ask the 2 (French ?) guys who recently worked with Github if they could review my commits.

I did my best because I love ExpressionEngine. I hope you'll appreciate my work. Keep in touch.
Emmanuel Beauchamps

ebeauchamps added some commits Jun 24, 2012

kevinsmith added a commit that referenced this pull request Sep 10, 2012

Merge pull request #4 from ebeauchamps/master
Many corrections made between June 24th and September 2nd

@kevinsmith kevinsmith merged commit 02068f0 into EllisLab:master Sep 10, 2012

Contributor

kevinsmith commented Sep 10, 2012

Sorry it took so long to merge in these changes, @ebeauchamps! The new notification preferences at GitHub are a bit confusing, and I ended up never receiving a notification that there was a pull request here waiting for us.

Thanks a million for your help here!

Contributor

ebeauchamps commented Sep 10, 2012

Thank you ! I guess Ellis Lab is still monitoring the #eecms hashtag on Twitter...good news!

I am so sorry for the number of commits! First, I have had some difficulties in working with GithHub, and second I changed my mind once or twice on a few corrections. That is why I won't be jealous if you prefer to ask someone else to review these corrections.

I'll be happy to help you if you ask so.

Thanks again.

Emmanuel Beauchamps
@ebeauchamps
@putitinred

Date: Mon, 10 Sep 2012 05:12:20 -0700
From: notifications@github.com
To: EE-Language-French@noreply.github.com
CC: e.bops@hotmail.fr
Subject: Re: [EE-Language-French] Many corrections made between June 24th and September 2nd (#4)

Sorry it took so long to merge in these changes, @ebeauchamps! The new notification preferences at GitHub are a bit confusing, and I ended up never receiving a notification that there was a pull request here waiting for us.

Thanks a million for your help here!

          —

          Reply to this email directly or view it on GitHub.
Contributor

kevinsmith commented Sep 10, 2012

No problem with the number of commits. GitHub nicely allows me to review all the changes as a single chunk, and while I can't verify the accuracy of the translation (my French is truly awful!), I didn't see any technical problems with the changes. Thanks again for being willing to help with the translation! We couldn't do it without you. :)

kevincupp pushed a commit that referenced this pull request Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment